-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hooks simplification #361
Merged
Merged
Hooks simplification #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the following changes:
TxHooks
has been split into two separate hooks:ApplyBlobTxHooks
andApplyBlobSequencerHooks
. These hooks now belong to thesov-modules-api
and are implemented insov-accounts
andsov-sequencer-registry
. Consequently, theDempAppHook
structure has been removed.TxVerifier
has been removed, and the stateless verification has been implemented insov-default-stf
. This verification only performs a signature check, and it makes sense to share it.These two changes have simplified the
AppTemplate
since it no longer requires the aforementioned structures as parameters.AppTemplate
requires thatRuntime
implementsApplyBlobTxHooks
andApplyBlobSequencerHooks
(the implementation is trivial).Now
ApplyBlobTxHooks
implementation forRuntime
has a well-defined structure and could be implemented as a macro, but it should be done in a separate PR.Linked Issues
Testing
All relevant tests are updated.
Docs
Relevant readmes updated (the biggest change in
demo-stf
)