feat: add serde feature for non-native serialization
#1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, serde serialization is enabled only if `native` feature is available. This aims to protect ZK targets to be bloated with functionality it won't use, increasing the binary size; hence, verification cost. However, serde is required outside ZK space, and without native features. One example is the wallet where we will perform JSON deserialization of a runtime call message inside of a WASM environment. WASM cannot have native (because it derives tokio), and must have serde available. This commit splits `serde` from `native`, making `native` optional for such functionality, but preserves the mandatory serde implementations under `native`.
bkolad
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, serde serialization is enabled only if
nativefeature is available. This aims to protect ZK targets to be bloated with functionality it won't use, increasing the binary size; hence, verification cost.However, serde is required outside ZK space, and without native features. One example is the wallet where we will perform JSON deserialization of a runtime call message inside of a WASM environment. WASM cannot have native (because it derives tokio), and must have serde available.
This commit splits
serdefromnative, makingnativeoptional for such functionality, but preserves the mandatory serde implementations undernative.