Skip to content

Commit

Permalink
add folder /inst/checks. We create a README file which containes a ta…
Browse files Browse the repository at this point in the history
…ble for checks.
  • Loading branch information
TolisChal committed Sep 23, 2018
1 parent 8fec5e4 commit bb416e6
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 4 deletions.
22 changes: 22 additions & 0 deletions R-proj/inst/checks/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
| Check | errors | warnings | NOTES |
| ----------------------- |:-------------:| :-------: | :---: |
| `devtools::check()` | 0 | 0 | 1 (`rand`) |
| `devtools::build_win()` | 0 | 0 | [2](https://win-builder.r-project.org/q9J85CboQuDA/00check.log) |
| `rhub::check_on_cran()` | 0 | 0 | [4](https://builder.r-hub.io/status/volesti_0.0.0.tar.gz-46af77102a0c4d3ca0a2593ce6e572a6) |
| `rhub::check_with_roldrel()` | 0 | 0 | [2](https://builder.r-hub.io/status/volesti_0.0.0.tar.gz-5828b5f9dd224ce48cfec44f2d74f398) |
| `rhub::check_with_rrelease()` | 0 | 0 | [1](https://builder.r-hub.io/status/volesti_0.0.0.tar.gz-b178259e61a14297823174769605f640) |
| `rhub::check_with_rpatched()` | 0 | 0 | [2](https://builder.r-hub.io/status/volesti_0.0.0.tar.gz-a0ff236c759748f29e4a6c59f278d3b9) |
| `rhub::check_with_rdevel()` | 0 | 0 | [2](https://builder.r-hub.io/status/volesti_0.0.0.tar.gz-da80904e99b045298a42c9922517f1a0) |
| `rhub::check_on_linux()` | 0 | 0 | [1](https://builder.r-hub.io/status/volesti_0.0.0.tar.gz-6cd434b931c345dca219cdf286c7a9a9) |
| `rhub::check_on_ubuntu()` | 0 | 0 | [1](https://builder.r-hub.io/status/volesti_0.0.0.tar.gz-00dbeb6b6daf47589cd24eb546a0725c) |
| `rhub::check_on_debian()` | 0 | 0 | [1](https://builder.r-hub.io/status/volesti_0.0.0.tar.gz-764ee37c6c3846b9b6a197eed59535eb) |
| `rhub::check_on_fedora()` | 0 | 0 | [1](https://builder.r-hub.io/status/volesti_0.0.0.tar.gz-1c6e19322fc9424a992eb5febf21b283) |
| `rhub::check_on_centos()` | [1](https://builder.r-hub.io/status/volesti_0.0.0.tar.gz-35342cfa3c984b4e84e60f4de51cd837) | 0 | 0 |
| `rhub::check_on_windows()` | 0 | 0 | [2](https://builder.r-hub.io/status/volesti_0.0.0.tar.gz-2d6fc57bb08d4ffabc00a3b0e7c7da66) |
| `Windows Server 2008 R2 SP1, R-release, 32/64 bit` | 0 | 0 | [2](https://builder.r-hub.io/status/volesti_0.0.0.tar.gz-9c665303f9f439b1d5e62022dcc436ff) |
| `Windows Server 2008 R2 SP1, R-patched, 32/64 bit` | 0 | 0 | [2](https://builder.r-hub.io/status/volesti_0.0.0.tar.gz-54525c454b65356d98181ac0a41ed889) |
| `Windows Server 2008 R2 SP1, R-devel, 32/64 bit` | [1](https://builder.r-hub.io/status/volesti_0.0.0.tar.gz-ad0349623bb47eaac00991fc7d6b4fab) | 0 | 0 |
| `macOS 10.9 Mavericks, R-oldrel` | 0 | 0 | [1](https://builder.r-hub.io/status/volesti_0.0.0.tar.gz-89ef6e055ca2fa9f2cc4bc2cf3c04fdb) |
| `macOS 10.11 El Capitan, R-release (experimental)` | [1](https://builder.r-hub.io/status/volesti_0.0.0.tar.gz-2ffda558566e3387bdd8a17922a4439d) | 0 | 0 |
| `Oracle Solaris 10, x86, 32 bit, R-patched (experimental)` | [1](https://builder.r-hub.io/status/volesti_0.0.0.tar.gz-d73aee5d20526bc68f3a885bbe979e6e) | 0 | 0 |

4 changes: 2 additions & 2 deletions cran_gen/cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ File ‘volesti/libs/volesti.so’:
Found ‘rand’, possibly from ‘rand’ (C)
Object: ‘vol_R.o’

Library lpSolveAPI uses rand() and srand() in lp_utils.c. We replace both functions with GetRNGstate(); PutRNGstate(); double unif_rand(); from R’s internal random number generation routines as it is proposed in `Writing R Extensions`. Moreover if you run in folder `/src`:
Library lpSolveAPI uses rand() and srand() in lp_utils.c. We replace both functions with GetRNGstate(); PutRNGstate(); unif_rand(); from R’s internal random number generation routines as it is proposed in `Writing R Extensions`. Moreover if you run in folder `/src`:
$ grep -r 'rand()'
You just get:
`utils.c: range *= (LPSREAL) unif_rand();`
which is our replacement. If you replace `rand()` with `srand` in grep search you get a null result.
This NOTE appears because of our functions in `/src/include/samplers` where word `rand` appears a lot of times, for example `rand_point_generator`.
This NOTE appears because of our functions in `/src/include/samplers` where word `rand` appears a lot of times, for example `rand_point_generator()`.

--------------------------------------------

Expand Down
4 changes: 2 additions & 2 deletions cran_gen/genCRANpkg.R
Original file line number Diff line number Diff line change
Expand Up @@ -128,5 +128,5 @@ devtools::build()
setwd(paste0(path,'/R-proj'))

# delete folder cran_package
dir_cr_pkg = paste0(path,'/cran_gen/cran_package')
unlink(dir_cr_pkg, recursive = TRUE)
#dir_cr_pkg = paste0(path,'/cran_gen/cran_package')
#unlink(dir_cr_pkg, recursive = TRUE)

0 comments on commit bb416e6

Please sign in to comment.