Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ngx-sortablejs with Angular 8 #163

Closed
3ddesign opened this issue Jun 19, 2019 · 15 comments
Closed

Using ngx-sortablejs with Angular 8 #163

3ddesign opened this issue Jun 19, 2019 · 15 comments

Comments

@3ddesign
Copy link

Ngx-sortablejs with Angular 8.0.1 does not work and does not show any errors.
Connected according to the documentation: https://www.npmjs.com/package/ngx-sortablejs
As I understand, the support of Angular 8 is already implemented?

@smnbbrv
Copy link
Member

smnbbrv commented Jun 19, 2019

Hi,

Please provide an example.

@3ddesign
Copy link
Author

sortable-test.zip

@3ddesign
Copy link
Author

Maybe it is somehow not properly connected? I can not figure out the reason (

@Gedmcq
Copy link

Gedmcq commented Jun 19, 2019

Hi,

have the same problem after upgrade, any updates?

@3ddesign
Copy link
Author

Hi,
I did not make updates. Created a project today with the latest versions:
"ngx-sortablejs": "3.1.1",
"sortablejs": "1.10.0-rc2"

@smnbbrv
Copy link
Member

smnbbrv commented Jun 19, 2019

hem. Looks like the problem is here

import { EventEmitter } from 'events';

Typo in import... I gonna fix it asap.

@smnbbrv
Copy link
Member

smnbbrv commented Jun 19, 2019

Try 3.1.2

@smnbbrv
Copy link
Member

smnbbrv commented Jun 19, 2019

Otherwise, please reproduce the issue on stackblitz.

See, with the wrong library installed it works right now:

https://stackblitz.com/edit/angular-8wg78w?file=src/app/app.module.ts

@3ddesign
Copy link
Author

This is strange, on stackblitz works fine, but if I download it locally, it does not work. You can reproduce it, I think the result will be the same

@smnbbrv
Copy link
Member

smnbbrv commented Jun 19, 2019

If I use the [email protected] then it works pretty well.

The issue seem to come in 1.10.0-rc2.

I don't really know what's changed there and fixing the potentially buggy RC version is also something I'd like to avoid.

So, I'd suggest using 1.9.0 for now

@3ddesign
Copy link
Author

sortable-test.zip

the same as here.
Can you reproduce it locally?

@smnbbrv
Copy link
Member

smnbbrv commented Jun 19, 2019

I can, and it works locally with 1.9.0

@smnbbrv
Copy link
Member

smnbbrv commented Jun 19, 2019

@3ddesign I created an issue on the main repo, let's wait for more info

@3ddesign
Copy link
Author

Yes, with version 1.9.0 works fine!
Thanks!

@Mantisimo
Copy link

Same here, 1.9.0 works for me! Cheers

@smnbbrv smnbbrv closed this as completed in 8fe60bc Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants