Angular issues with 1.10 rc versions

[smnbbrv]

Problem:

Hi @owen-m1 and Co,

The angular users report, that the library does not work after upgrade to rc versions.

Are there known breaking changes? What could be the issue that the code that worked previously (1.7 -> 1.9) stopped working now

See SortableJS/ngx-sortablejs#163

JSBin/JSFiddle demonstrating the problem:

Please see the attached issue

---

Before you create an issue, check it:

1. Try master-branch, perhaps the problem has been solved;
2. Use the search, maybe we already have an answer;
3. If not found, create an example on jsbin.com (draft) and describe the problem.

Bindings:

• Angular
  • 2.0+: https://github.com/SortableJS/angular-sortablejs/issues
  • legacy: https://github.com/SortableJS/angular-legacy-sortablejs/issues
• React
  • ES2015+: https://github.com/SortableJS/react-sortablejs/issues
  • mixin: https://github.com/SortableJS/react-mixin-sortablejs/issues
• Polymer: https://github.com/SortableJS/polymer-sortablejs/issues
• Knockout: https://github.com/SortableJS/knockout-sortablejs/issues
• Meteor: https://github.com/SortableJS/meteor-sortablejs/issues

[owen-m1]

I took a look at it, and I am not sure. There aren't any error messages, so there must be an issue with ngx-sortablejs interacting with Sortable somehow. There aren't any breaking changes that I know of between 1.9.0 and 1.10.0-rc2.

I think you are in a better position for figuring this out than me. The fact that it works on StackBlitz and not locally makes me think it has something to do with the way angular is building it. But again, I have no idea :/

The only thing I can think of is that this is now the entry point of the ESM that is imported when import Sortable from 'sortablejs' is called: https://github.com/SortableJS/Sortable/blob/master/entry/entry-defaults.js
But it still has Sortable as the default export, so I don't know why that would affect it.

[smnbbrv]

Thanks, the latter could be very useful! I’ll check the ways how it can be imported differently

[smnbbrv]

Here is the output of require('sortablejs')

1.9.0 (and former):

1.10.rc-2

That's a breaking change still... I have nothing against, just want to know whether it will be kept like that.

Doesn't this version deserve to be 2.0.0?

[owen-m1]

@smnbbrv I never thought about anyone using the require syntax.
It is backwards compatible for import Sortable from 'sortablejs';, because the default export is the same, but it seems the require function does not respect default exports.

Is this what is causing ngx-sortablejs to break? If so, where is this require method being called in the code/build?

[smnbbrv]

Yeppers, here is a permalink

https://github.com/SortableJS/ngx-sortablejs/blob/337eb0d3ab81cd144d8e35ca815c1e2b0886aea0/projects/ngx-sortablejs/src/lib/sortablejs.directive.ts#L8

As I can remember formerly I was forced to use require syntax because of the broken typescript typings. Now I can rework it in a way it uses default export, so it is fine for me.

However this is going to be closely connected to the #1547 . The typings are messy now.

I would close this issue then and raise a newer (probably a major version) on ngx-sortablejs in the near future.

[waynevanson]

@owen-m1 @smnbbrv Is this actuall allowed in the sortablejs package?

import { Sortable } from 'sortablejs';

I'm in the middle of a PR and can add this in if it works, I just need confirmation.

[owen-m1]

@waynevanson Yes you are able to import Sortable that way

[waynevanson]

@owen-m1 Can you link to source code for this? I wanna make sure I get the correct typings #1547

[owen-m1]

@waynevanson

Sortable/entry/entry-core.js

Line 10 in 5a8603d

Sortable,