Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'fixing dimensions' because it breaks dimensions #1404

Closed
wants to merge 1 commit into from
Closed

Remove 'fixing dimensions' because it breaks dimensions #1404

wants to merge 1 commit into from

Conversation

dword-design
Copy link

In my implementation this code snippet breaks my dimensions instead of fixing them. Without it, it works like a charm. Why is this snippiet needed and how does the calculation work?

@owen-m1
Copy link
Member

owen-m1 commented Dec 12, 2018

@dword-design I honestly don't even know why that's there. It seems like it would just be setting the width to the exact same thing. How does it break the dimensions in your implementation?

@dword-design
Copy link
Author

@owen-m1 In my app it leads to the top and bottom padding being missing when dragging (at least as far as I see it).

@owen-m1
Copy link
Member

owen-m1 commented Dec 18, 2018

@dword-design Solved in ad9efbd

Your PR did not fully solve the problem, the issue was that getBoundingClientRect gave the border-box dimensions, while setting height and width set the content-box dimensions.

@owen-m1 owen-m1 closed this Dec 18, 2018
@dword-design
Copy link
Author

@owen-m1 great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants