Swap Branch Fixes #1361
Closed
Swap Branch Fixes #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug with swapping animation when items are next to each other Fixes bug when dragged item is the last sibling
|
FYI if you merge your ...or, if this one includes all of the other stuff as well, close the other one out and direct to this one being merged. |
|
OOOH wait, I see, he made a separate 'swap' branch but then never merged that. |
|
Updated pull request: #1430 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks again for taking the time to create the swap branch! Still hoping it can get merged into master eventually. I've fixed a couple bugs I found once I started using it, and I added a new property to the end event object that holds the item being swapped with. The argument list in the _dispatchEvent method seems to be getting a little crazy, so I just added one more to be able to tack on miscellaneous extra event properties.
Adds swapItem property to end event when swapping
Fixes bug with swapping animation when items are next to each other
Fixes bug when dragged item is the last sibling