Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When flex-direction: column, dragging doesn't work as expected #869

Closed
Horray opened this issue Jun 10, 2016 · 4 comments
Closed

When flex-direction: column, dragging doesn't work as expected #869

Horray opened this issue Jun 10, 2016 · 4 comments

Comments

@Horray
Copy link

Horray commented Jun 10, 2016

I'm trying to implement this in my project, by my project requires the tiles to be flex-direction: column. When I do that, and drag horizontally, the tile under the tile I'm about to drop it on, swaps with the one under it.

Kinda hard to explain. Here's a gif explaining:

Image

Here's the JSFIddle

@RubaXa
Copy link
Collaborator

RubaXa commented Jun 22, 2016

Alas, no solution to this problem (more than 2 years).

Horray added a commit to Horray/Sortable that referenced this issue Jun 24, 2016
@Horray
Copy link
Author

Horray commented Jun 24, 2016

@RubaXa Thanks for replying! Actually, it's been 13 days since I asked the question. (Not sure why you said 2 years. lol)

Anyway, I made a pull request: #891

Let me know what you think. Thanks!

@emielmolenaar
Copy link

Any workaround or solution? Thanks!

gazugafan added a commit to gazugafan/Sortable that referenced this issue Jan 28, 2018
This is a rough implementation of a swapping feature. Setting the new "swap" option to true will cause a dragged item to be swapped with the item you drop it on (instead of inserted next to it). The item being hovered over (and potentially swapped with) will be highlighted by adding the class specified in the new "swapHighlightClass" option (defaults to "sortable-swap-highlight"). When swapping is enabled, the "end" event's "to" property will be set to the item being dropped on and swapped with.

It's a bit hackish, but it works as a solution to issues SortableJS#1211, SortableJS#1082, SortableJS#1072, SortableJS#891, SortableJS#869, and SortableJS#469. Maybe it can at least serve as a starting off point to adding this feature to master eventually? Thanks!
@owen-m1
Copy link
Member

owen-m1 commented Dec 15, 2018

Solved in 1.8.0-rc1
#592 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants