ng-sortable doesn't work in Safari 8

[demisx]

I am on Mac Yosemite 10.10.2. The ng-sortable doesn't work in Safari 8. You can see this with your demo fiddle http://jsbin.com/naduvo/1/edit?html,js,output

[evillemez]

I can confirm this - same versions of OS X/Safari. It's working in Chrome 40 for me.

Unfortunately it's not clear at all what's wrong. No error messages, it just doesn't do anything.

[evillemez]

Actually, this probably isn't related to ng-sortable specifically, but the underlying sortable implementation. None of the demos at http://rubaxa.github.io/Sortable/ are sorting in Safari 8 either.

[evillemez]

Lots of console.logs later, I've traced it (I think) to this line:
https://github.com/RubaXa/Sortable/blob/master/Sortable.js#L662

In Chrome, this condition is met, but not in Safari 8. If I can figure out what's going on I'll submit a PR.

[evillemez]

@RubaXa I saw you added an angular label - it's not really angular that's the problem though, it's Sortable.js in general that is broken in Safari 8. We just discovered it while trying to use ng-sortable. Should I start a new issue for this since the name is misleading?

[RubaXa]

Yes, you're right, it just does not work 0_o.

[demisx]

@evillemez 👍

[RubaXa]

https://github.com/RubaXa/Sortable/blob/master/Sortable.js#L485 — (!) effectAllowed always all 💩

[evillemez]

I'm not sure if that's it... I found some odd behavior in Safari related to the line I mentioned earlier:

https://github.com/RubaXa/Sortable/blob/master/Sortable.js#L662

Logging both of the elements in that condition gives me different results in Safari vs Chrome.

Safari 8:

• dragEl.nextSibling: <!-- end ngRepeat: skill in skills -->
• nextEl: <!-- end ngRepeat: skill in skills -->

But, in Chrome 40, logging both elements, I get:

• dragEl.nextSibling: <li ng-repeat="skill in skills" class="ng-binding ng-scope">Foo</li>
• nextEl: <!-- end ngRepeat: skill in skills -->

[evillemez]

ack, sorry, editing message - put wrong info in it

[evillemez]

So, in Safari 8, for both elements it has the comment nodes injected by ng-repeat

[RubaXa]

Try dev-branch.

[evillemez]

@RubaXa Ah, you are my hero - that fixed it.

[RubaXa]

Actually sorry that it happened, it's my fault that has not checked in Safari (although this is a bug in it).

[evillemez]

No worries, still a good library, thanks for writing it :) Спасибо огромное!

[demisx]

Any way this could be covered in tests?

[RubaXa]

Automatically? it's impossible, only manual testing.

[evillemez]

Well, it's probably doable with Saucelabs, but it's not trivial to set up.

https://saucelabs.com

[RubaXa]

Not sure that Selenium correctly reproduces all events with drag and drop.