-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onEnd event oldIndex/newIndex properties behavior changed in 1.7 -> 1.8 #1472
Comments
@netcitylife This was intended as many people had issues when using SortableJS with frameworks such as vuedraggable where the indexes were breaking the sorting because they did not include all elements |
Ok, but then you should have released 1.8 as 2.0, because this is a backward incompatible change and our applications broke after updating... |
I agree this change was ignorant on my part. I can add these properties. |
That would be great! Thanks |
Added in 4ca519e. |
Problem:
After updating from 1.7 to 1.8 behavior of
event.oldIndex
/event.newIndex
changed when usingdraggable
property to restrict sortable elements. In 1.7 index values were relative to sortable elements array only, but in 1.8 they are relative to all elements present in sortable parent, not only those ones which are actually sortable (limited withdraggable
property).JSBin/JSFiddle demonstrating the problem:
The text was updated successfully, but these errors were encountered: