Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drag bug in Safari #1436

Closed
sseulki-lee opened this issue Jan 28, 2019 · 4 comments
Closed

Drag bug in Safari #1436

sseulki-lee opened this issue Jan 28, 2019 · 4 comments

Comments

@sseulki-lee
Copy link

I have problem in safari when dragging elements
In _onTouchMove, it's returned at Sortable.js#L962

I guess it's because safari don't support PointerEvent
so just listen MouseEvent by Sortable.js#L866
(i guess.. MouseEvent's cancelable is set false by default)

so please let me know why Sortable.js#L962 is inserted
and i want to fix this bug
@owen-m1
Copy link
Member

owen-m1 commented Jan 28, 2019

I thought it would help prevent touchmove firing when the page is scrolling due to touch move, since the event isn't usually canceable when that happens... But if it causes problems I will remove it and you should in your install.

@owen-m1
Copy link
Member

owen-m1 commented Jan 28, 2019 •
edited
Loading

@sseulki-lee
Does the tap event get through on Safari at Sortable.js#L619?

@sseulki-lee
Copy link
Author

@owen-m1
tap event is okay on safari.
it isn't returned at Sortable.js#L619

owen-m1 added a commit that referenced this issue Feb 10, 2019
@owen-m1
#1436: Allow touchmove if not cancelable
41fd3e4
@owen-m1
Copy link
Member

owen-m1 commented Feb 10, 2019

1.8.2 has the fix

@owen-m1 owen-m1 closed this as completed Feb 10, 2019
This was referenced Sep 23, 2019
Open
Open
elo7-developer pushed a commit to elo7/Sortable that referenced this issue Nov 18, 2019
@owen-m1 @elo7-developer
SortableJS#1436: Allow touchmove if not cancelable
a26d7e7
@snyk-bot snyk-bot mentioned this issue Mar 17, 2020
Open
Runi-c pushed a commit to Tupperbox/Sortable that referenced this issue Nov 10, 2023
@owen-m1
SortableJS#1436: Allow touchmove if not cancelable
aac4b98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@owen-m1 @sseulki-lee