Test failure on ghc 9.10

[eldritch-cookie]

katip-testsuite.log

[MichaelXavier]

Can you try this with 0.8.8.2? I tried running the test suite a few dozeN times and it didn't fail. The test log didn't have a seed value or anything so I don't know how to reproduce this.

[eldritch-cookie]

yes i can run the testsuite on 0.8.8.2 it fails again katip-0.8.8.2-build.log
the test that failed is the one on line 163

katip/katip/test/Katip/Tests.hs

Line 163 in af85a1f

testCase "Katip.Monadic.logLocM" $ do

not a quickcheck test, the error is a call to head so it probably is caused by

katip/katip/test/Katip/Tests.hs

Line 168 in af85a1f

let loc = _itemLoc (head loggedItems)

but i have no idea why loggedItems is an empty list.

[9999years]

Comes from here:

katip/katip/src/Katip/Core.hs

Line 1155 in af85a1f

xs -> Just . toLoc . head $ filter filterKatip xs

[9999years]

Cabal changed the package names, which getLoc uses to filter out katip traces. With cabal-3.12:

       name   | srcLocPackage
entry: getLoc | katip-0.8.8.2-inplace
entry: logLocM | katip-0.8.8.2-inplace-test

With cabal-3.10:

entry: getLoc | katip-0.8.8.2-inplace
entry: logLocM | main

It's actually not related to 9.10 at all, you can reproduce on 9.8 with Cabal 3.12 or have tests pass on 9.10 with Cabal 3.10...

[MichaelXavier]

@9999years Do you understand the issue well enough to write up a fix? I'd be more than happy to merge and release it but I don't have much time to chase this down.

[9999years]

@MichaelXavier I think factoring the tests out into a separate package whose name doesn't start with katip- would work.

[maksar]

Also worth noting, that some golden files are not in the repo:

    Text-golden:                                                        OK
      Golden file did not exist; created
    Json-golden:                                                        OK
      Golden file did not exist; created

[juhp]

Also failed for Stackage Nightly