Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SN32 boards cleanup #396

Merged
merged 4 commits into from
Nov 24, 2024
Merged

Conversation

dexter93
Copy link

@dexter93 dexter93 commented Sep 11, 2024

There is no reason for shared key/led matrix keyboards to nerf plain keyboard setups.
Make a new board for them that preselects PWM and disables SWD/RESET pins since they're usually allocated as part of the matrix

usage: in keyboard.json/info.json

    "development_board": "sn32f240b_shared_matrix"

instead of the old

    "processor": "SN32F248BF",
    "bootloader": "sn32-dfu",

since those are preselected now

Description

Requires ChibiOS/ChibiOS-Contrib#411

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link

github-actions bot commented Nov 7, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale label Nov 7, 2024
@dexter93 dexter93 added in progress and removed stale labels Nov 7, 2024
@dexter93 dexter93 merged commit 206c35a into SonixQMK:sn32_develop Nov 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant