Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[review] feat: Reporting top N slowest examples #38

Merged
merged 3 commits into from
Dec 24, 2024
Merged

Conversation

kzkn
Copy link
Contributor

@kzkn kzkn commented Dec 24, 2024

No description provided.

Copy link

😰 RSpec failure

25 examples, 1 failure
Example Description Message
spec/activestorage/validator/blob_spec.rb:37 ActiveRecord::Validations::BlobValidator with size_range option 1.4MB is expected to eq true expected: true got: false (compared using ==)

Copy link

Slowest examples

Top 10 slowest examples (0.17 seconds, 60.88% of total time)
Example Description Time in seconds
spec/activestorage/validator/blob_spec.rb:11 ActiveRecord::Validations::BlobValidator presence: true has_one_attached is expected to eq true 0.04451
spec/activestorage/validator/blob_spec.rb:37 ActiveRecord::Validations::BlobValidator with size_range option 1.4MB is expected to eq true 0.03847
spec/activestorage/validator/blob_spec.rb:10 ActiveRecord::Validations::BlobValidator presence: true has_one_attached is expected to eq false 0.01624
spec/activestorage/validator/blob_spec.rb:36 ActiveRecord::Validations::BlobValidator with size_range option 1.4MB is expected to eq false 0.01501
spec/activestorage/validator/blob_spec.rb:39 ActiveRecord::Validations::BlobValidator with size_range option 1.4MB should translate the validation error according to it's locale 0.015
spec/activestorage/validator/blob_spec.rb:80 ActiveRecord::Validations::BlobValidator with content_type option symbol is expected to eq true 0.01165
spec/activestorage/validator/blob_spec.rb:54 ActiveRecord::Validations::BlobValidator with content_type option regexp is expected to eq true 0.00984
spec/activestorage/validator/blob_spec.rb:68 ActiveRecord::Validations::BlobValidator with content_type option array is expected to eq false 0.0098
spec/activestorage/validator/blob_spec.rb:71 ActiveRecord::Validations::BlobValidator with content_type option array is expected to eq false 0.00957
spec/activestorage/validator/blob_spec.rb:55 ActiveRecord::Validations::BlobValidator with content_type option regexp is expected to eq false 0.00918

@aki77 aki77 merged commit 34294b5 into main Dec 24, 2024
2 checks passed
@kzkn kzkn deleted the kzkn-20241223 branch December 24, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants