Feature/improve configuration #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheDen
reviewed
Aug 21, 2023
| @@ -24,9 +25,9 @@ type CollageRequest struct { | |||
| Period string `in:"query=period;default=7day" validate:"required,validatePeriod"` | |||
| Height uint `in:"query=height;default=0" validate:"gte=0,lte=3000"` | |||
| Width uint `in:"query=width;default=0" validate:"gte=0,lte=3000"` | |||
| Rows int `in:"query=rows;default=3" validate:"required,gte=1,lte=20"` | |||
| Rows int `in:"query=rows;default=3" validate:"required"` | |||
There was a problem hiding this comment.
I noticed you removed lte and gte—is the idea to set the max by the amount of images and not grid size?
There was a problem hiding this comment.
Yeah, I removed this validation as we do another validation a bit later to check the total number of images. Also made it easier to set the max number of images with the env variable.
TheDen
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more configuration so we can more easily do things like update the max images and increase the size of the images we use.
Currently this is only for the backend. Not sure the best way to integrate this into the frontend