Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLVS-1559 Embed Enterprise dotnet analyzer #5787

Merged
merged 13 commits into from
Oct 31, 2024
Merged

SLVS-1559 Embed Enterprise dotnet analyzer #5787

merged 13 commits into from
Oct 31, 2024

Conversation

georgii-borovinskikh-sonarsource
Copy link
Contributor

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource commented Oct 29, 2024 •
edited by jira bot
Loading

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource changed the title SLVS-1559 SLVS-1559 Embed Enterprise dotnet analyzer Oct 30, 2024
@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource marked this pull request as ready for review October 30, 2024 13:49
gabriela-trutan-sonarsource
gabriela-trutan-sonarsource requested changes Oct 31, 2024
View reviewed changes
src/Integration.Vsix.UnitTests/EmbeddedAnalyzers/EmbeddedAnalyzerDLLsSmokeTest.cs Outdated Show resolved Hide resolved
src/Integration.Vsix/EmbeddedAnalyzers/EmbeddedRoslynAnalyzersLocator.cs Outdated Show resolved Hide resolved
src/SLCore/Common/Helpers/LanguageExtensions.cs
@@ -43,8 +43,8 @@ public static string GetPluginKey(this Language language) =>
{
Language.C or Language.CPP => "cpp",
Language.JS or Language.TS or Language.CSS => "javascript",
Language.CS => "csharp",
Language.VBNET => "vbnet",
Language.CS => "csharpenterprise",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to adapt also the code here:

sonarlint-visualstudio/src/Infrastructure.VS/ErrorListHelper.cs

Line 145 in cf54d9b

"SonarAnalyzer.CSharp" => $"{SonarRuleRepoKeys.CSharpRules}:{errorCode}",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And enhance the test:

sonarlint-visualstudio/src/Infrastructure.VS.UnitTests/ErrorListHelperTests.cs

Line 234 in cf54d9b

[DataRow("S666", "csharpsquid", "S666", "SonarAnalyzer.CSharp", null)]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, rule ids are the same for both plugins

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not talking about the rule id. In the ErrorListHelper we have a switch statement for the "buildTool".

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that thing. They broke it in one of the VS updates, so we no longer rely on it. I will see if I need to update this for backwards compatibility

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

src/SLCore/Common/Helpers/LanguageExtensions.cs Show resolved Hide resolved
build/CopyDependencies/CopyDependencies.targets Show resolved Hide resolved
gabriela-trutan-sonarsource
gabriela-trutan-sonarsource approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed to rename the interface "IEmbeddedRoslynAnalyzersLocator" to "IEmbeddedDotnetAnalyzersLocator"

@georgii-borovinskikh-sonarsource
Copy link
Contributor Author

You missed to rename the interface "IEmbeddedRoslynAnalyzersLocator" to "IEmbeddedDotnetAnalyzersLocator"

Why didn't it do it automatically....

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource merged commit 3592f69 into feature/dotnet-analyzer-repackaging Oct 31, 2024
2 checks passed
@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource deleted the gb/enterprise-analyzer-packaging branch October 31, 2024 14:38
georgii-borovinskikh-sonarsource added a commit that referenced this pull request Nov 5, 2024
@georgii-borovinskikh-sonarsource
SLVS-1559 Embed Enterprise dotnet analyzer (#5787)
26221a3 
[SLVS-1559](https://sonarsource.atlassian.net/browse/SLVS-1559)

[SLVS-1559]:
https://sonarsource.atlassian.net/browse/SLVS-1559?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource gabriela-trutan-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgii-borovinskikh-sonarsource @gabriela-trutan-sonarsource