SLVS-1510 Add IEmbeddedRoslynAnalyzerProvider & IConnectedModeRoslynAnalyzerProvider #5749
Conversation
georgii-borovinskikh-sonarsource
requested a review
from gabriela-trutan-sonarsource
|
|
||
| namespace SonarLint.VisualStudio.Infrastructure.VS.Roslyn; | ||
|
|
||
| /// <summary> |
There was a problem hiding this comment.
This comment belongs better to the Get method
| /// </summary> | ||
| public interface IConnectedModeRoslynAnalyzerProvider | ||
| { | ||
| ImmutableArray<AnalyzerFileReference>? GetOrNull(ServerConnection connection); |
There was a problem hiding this comment.
I think there is no need to call the method GetOrNull or it is obvious from the return type that it can be null
Get should be enough or GetAnalyzers
There was a problem hiding this comment.
I just named it like that to be explicit about what the contract of this method
There was a problem hiding this comment.
Isn't the return type explicit enough?
There was a problem hiding this comment.
Is it a big deal to have it in the name? I feel like it doesn't hurt at all
There was a problem hiding this comment.
Feels superfluous and I feel like naming is important. But I guess you can leave it.
| namespace SonarLint.VisualStudio.Infrastructure.VS.Roslyn; | ||
|
|
||
| /// <summary> | ||
| /// Returns SonarAnalyzer.CSharp & SonarAnalyzer.VisualBasic analyzer DLLs that are embedded in the VSIX |
There was a problem hiding this comment.
Move the documentation to the get method
| /// <summary> | ||
| /// Returns SonarAnalyzer.CSharp & SonarAnalyzer.VisualBasic analyzer DLLs that are downloaded from the server for the current binding | ||
| /// </summary> | ||
| public interface IConnectedModeRoslynAnalyzerProvider |
There was a problem hiding this comment.
Consider if Repository might be a better name
There was a problem hiding this comment.
I would like to keep the provider and the writer interfaces split. The implementation could have Repository in the name though
|
georgii-borovinskikh-sonarsource
merged commit e4627c9
into
feature/dotnet-analyzer-repackaging
georgii-borovinskikh-sonarsource
deleted the
gb/analyzer-provider-interfaces
branch
SLVS-1510