SLE-990,SLE-989: Prepare patch, only rely on JGit from SonarLint CORE #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't rely on EGit or JGit coming with Eclipse anymore but the bundled JGit version from SonarLint CORE. This is due to Eclipse IDE 4.33 (2024-09) coming with EGit and JGit that requires Java 17
Remove all the leftover dependency and incorrect mentions of EGit. Also streamline the VcsService and JGitFacade after removing the EGit dependency and related code.
thahnen
force-pushed
the
fix/tha/PreparePatch
branch
from
d88f727 to
73857e1
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLE-990
SLE-989
Summary
Since Eclipse IDE 4.33 (2024-09) the EGit and JGit versions coming bundled with the IDE require Java 17 to run. As SonarLint for Eclipse still runs on Java 11 this won't work and fail on all operations that are accessing the branch check or whether a file is ignored or not.
Therefore, the JGit version from SonarLint CORE is used by shading/relocating it into the OSGi bundle and consuming it, additionally removing the dependency on the IDE to come with EGit or JGit.
The JGit implementation was implemented following more or less what was done on SLCORE but excluding all the stuff that is not required in the context of the IDE. The stuff from SLCORE could therefore not be re-used and also was in the
backendmodules hidden.