SLE-968: Handle index exclusions correctly for CDT on Windows #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because CDT didn't follow the norm of putting forward slashes as resource identifiers for output directories of build configurations, we were incorrectly handling Windows and in special cases excluded the whole project from being indexed.
|
gabriela-trutan-sonarsource
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLE-968
Summary
Because CDT didn't follow the norm of putting forward slashes as resource identifiers for output directories of build configurations, we were incorrectly handling Windows and in special cases excluded the whole project from being indexed.
This could be CDT projects generated from CMake via the following command in the project directory (here is a Unix example, should be the same with Windows and Makefiles):
Or when users configured their Eclipse CDT project files (e.g. on a CDT Managed Build) to use the project directory as the build directory or when using normal Makefile-based projects imported into Eclipse CDT.
Testing
There are currently no CDT-related tests on the CI, but there is a ticket for it to be tackled in the next iteration. Tried it with a Windows VM.