SC-1063 provide orb that adds support for SonarCloud in CircleCI #2
Conversation
tom-vanbraband-sonarsource
force-pushed
the
feature/tom/SC-1063/orb
branch
from
b33861b
to
a9eaa9b
Compare
README.md
Outdated
| ```yaml | ||
| version: 2.1 | ||
| orbs: | ||
| sonarcloud: sonarsource/sonarcloud@dev:alpha |
There was a problem hiding this comment.
I think we can already change to v1.0.0
tom-vanbraband-sonarsource
force-pushed
the
feature/tom/SC-1063/orb
branch
2 times, most recently
from
3306dd0
to
97315d6
Compare
tom-vanbraband-sonarsource
force-pushed
the
feature/tom/SC-1063/orb
branch
from
97315d6
to
920f783
Compare
| command: mkdir -p /tmp/cache/scanner | ||
| - restore_cache: | ||
| keys: | ||
| - v<<parameters.cache_version>>-sonarcloud-scanner-4.1.0.1829 |
There was a problem hiding this comment.
The scanner version does not need to be part of the cache key. The cached files are compatible with all versions of scanners.
| - v<<parameters.cache_version>>-sonarcloud-scanner-4.1.0.1829 | |
| - v<<parameters.cache_version>>-sonarcloud-scanner |
There was a problem hiding this comment.
That looks like a cache for the (versioned) sonar-scanner executable, not necessarily a cache of generated files
(sorry to butt in here, I've been following this issue, and have already created a similar orb myself)
There was a problem hiding this comment.
Indeed, the cache will hold the scanner executable, and the plugins downloaded by the scanner. It is not a big deal if we remove it, but if we ever want to use another scanner executable version then we should change the cache name.
There was a problem hiding this comment.
@tom-vanbraband-sonarsource, have you been able to get it to avoid downloading plugins by caching? It seems that even when I'm using a cache, sonar-scanner still downloads plugins every time, and it's the longest 17 seconds of my life.
There was a problem hiding this comment.
no I failed to make it work.
There was a problem hiding this comment.
Hi @jrnail23, the SONAR_USER_HOME variable determines among other things the directory where your downloaded plugins are stored. So you can use that to make sure that your plugins are stored within the circleci cache directory.
| environment: | ||
| SONARQUBE_SCANNER_PARAMS: '{"sonar.host.url":"https://dogfood-core.sc-dev.io"}' | ||
| - save_cache: | ||
| key: v<<parameters.cache_version>>-sonarcloud-scanner-4.1.0.1829 |
There was a problem hiding this comment.
| key: v<<parameters.cache_version>>-sonarcloud-scanner-4.1.0.1829 | |
| key: v<<parameters.cache_version>>-sonarcloud-scanner |
src/main/commands/scan.yml
Outdated
|
|
||
| $SCANNER_DIRECTORY/sonar-scanner-$VERSION-$OS/bin/sonar-scanner | ||
| environment: | ||
| SONARQUBE_SCANNER_PARAMS: '{"sonar.host.url":"https://dogfood-core.sc-dev.io"}' |
There was a problem hiding this comment.
do not forget to replace sonarcloud.io!
| SONARQUBE_SCANNER_PARAMS: '{"sonar.host.url":"https://dogfood-core.sc-dev.io"}' | |
| SONARQUBE_SCANNER_PARAMS: '{"sonar.host.url":"https://sonarcloud.io"}' |
tom-vanbraband-sonarsource
force-pushed
the
feature/tom/SC-1063/orb
branch
from
50ecae0
to
f70c359
Compare
ghost
merged commit 
No description provided.