Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYSCAN-61: CI update pre-release to release on testPyPI #47

Merged
merged 1 commit into from
May 6, 2024

Conversation

joke1196
Copy link
Contributor

@joke1196 joke1196 commented May 6, 2024

No description provided.

Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@joke1196 joke1196 requested a review from ghislainpiot May 6, 2024 13:08
Copy link
Contributor

@ghislainpiot ghislainpiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

uses: SonarSource/gh-action_release/.github/workflows/main.yaml@v5
with:
publishToTestPyPI: true
skipPythonReleasabilityChecks: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to skip those checks ? I didn't really find much documentation on that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes sorry I had to dig into the implementation to find that for the moment these checks are not reliable: https://github.com/SonarSource/gh-action_release/blob/a6f57de1b1c23b7cd4f4eceab350ee4aca2cca0d/.github/workflows/main.yaml#L69

@joke1196 joke1196 merged commit daf9e8f into master May 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants