PYSCAN-43 Ensure CLI arguments to the sonar-scanner-cli are provided intentionally #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaume-dequenne-sonarsource
force-pushed
the
PYSCAN-43
branch
3 times, most recently
from
2e84c5e
to
3999baf
Compare
guillaume-dequenne-sonarsource
changed the title
guillaume-dequenne-sonarsource
force-pushed
the
PYSCAN-43
branch
from
3999baf
to
b931865
Compare
guillaume-dequenne-sonarsource
requested review from
maksim-grebeniuk-sonarsource and
joke1196
guillaume-dequenne-sonarsource
force-pushed
the
PYSCAN-43
branch
from
b931865
to
8164cce
Compare
|
joke1196
approved these changes
Jan 19, 2024
| def test_minimal_project_unexpected_arg(sonarqube_client: SonarQubeClient): | ||
| process = CliClient().run_analysis(sonarqube_client, params=["-unexpected"], sources_dir="minimal") | ||
| assert process.returncode == 0 | ||
| assert "ERROR: Unrecognized option: -unexpected" in process.stdout |
There was a problem hiding this comment.
I was wondering if the sonar cli was writing to the STDERR stream when an error is encountered. If this is the case we could check that STDERR is empty or assert on errors. But I think for now this is totally fine like this! It is just an idea for the next iteration linked to this ticket
maksim-grebeniuk-sonarsource
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.