Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCANNPM-57 Properly format and send arguments to the Scanner Engine #180

Merged
merged 2 commits into from
Dec 12, 2024
Merged

SCANNPM-57 Properly format and send arguments to the Scanner Engine #180

merged 2 commits into from
Dec 12, 2024

Conversation

7PH
Copy link

@7PH 7PH commented Nov 28, 2024

@7PH 7PH changed the title SCANNPM-57 Allow equal signs in CLI arguments SCANNPM-57 Allow equal signs in CLI arguments & Forward Java Opts to Scanner Engine Nov 28, 2024
@7PH 7PH changed the title SCANNPM-57 Allow equal signs in CLI arguments & Forward Java Opts to Scanner Engine SCANNPM-57 Property format and send arguments to the Scanner Engine Nov 28, 2024
lucas-paulger-sonarsource
lucas-paulger-sonarsource approved these changes Nov 28, 2024
View reviewed changes
Copy link

@lucas-paulger-sonarsource lucas-paulger-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FV done, looks good 👍🏻

@7PH 7PH requested a review from a team November 28, 2024 09:30
vdiez
vdiez approved these changes Dec 2, 2024
View reviewed changes
Copy link

@vdiez vdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@7PH 7PH changed the title SCANNPM-57 Property format and send arguments to the Scanner Engine SCANNPM-57 Properly format and send arguments to the Scanner Engine Dec 2, 2024
@7PH 7PH force-pushed the bugfix/br/scannpm-57-equal-sign-cli branch from be5784f to 62eabb1 Compare December 3, 2024 10:15
@7PH 7PH force-pushed the bugfix/br/scannpm-57-equal-sign-cli branch from 62eabb1 to 8306bb2 Compare December 12, 2024 09:03
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@7PH 7PH merged commit 1903754 into master Dec 12, 2024
7 checks passed
@7PH 7PH deleted the bugfix/br/scannpm-57-equal-sign-cli branch December 12, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-paulger-sonarsource lucas-paulger-sonarsource lucas-paulger-sonarsource approved these changes

@vdiez vdiez vdiez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@7PH @vdiez @lucas-paulger-sonarsource