Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCANMAVEN-233 check that sonar.java.jdkHome has default value even without configuration from user #249

Merged
merged 7 commits into from
Oct 30, 2024
Merged

SCANMAVEN-233 check that sonar.java.jdkHome has default value even without configuration from user #249

merged 7 commits into from
Oct 30, 2024

Conversation

erwan-serandour
Copy link
Contributor

@erwan-serandour erwan-serandour commented Oct 28, 2024 •
edited by jira bot
Loading

dorian-burihabwa-sonarsource
dorian-burihabwa-sonarsource requested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can improve by adding another test and ensuring that we check the effective values set.

its/src/test/java/com/sonar/maven/it/suite/JavaTest.java Outdated Show resolved Hide resolved
its/src/test/java/com/sonar/maven/it/suite/JavaTest.java Outdated Show resolved Hide resolved
dorian-burihabwa-sonarsource
dorian-burihabwa-sonarsource approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, I would suggest removing the imports before merging to avoid having to open a new PR to fix the QG

its/src/test/java/com/sonar/maven/it/suite/JavaTest.java Outdated Show resolved Hide resolved
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@erwan-serandour erwan-serandour merged commit 69c0e1a into master Oct 30, 2024
19 checks passed
@erwan-serandour erwan-serandour deleted the erwan/jdkHomeTest branch October 30, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erwan-serandour @dorian-burihabwa-sonarsource