SONARPY-2188 Introduce UnresolvedImportedType #2056
Conversation
| .orElse(null); | ||
| } | ||
| } | ||
| } else if (resolvedType instanceof UnknownType || (resolvedType instanceof ObjectType objectType && objectType.type() instanceof UnknownType)) { |
There was a problem hiding this comment.
Do we get ObjectType[UnknownType] somewhere? Is it expected? We probably want to avoid it (should we create a ticket?)
There was a problem hiding this comment.
We do get them.
They are probably coming from the converters and the systematic wrapping in ObjectType.
I think right now, it is unexpected and is happening for the wrong reasons.
I will create a ticket
In the future, I think we might have some. As long as we know for sure it is an object.
| } | ||
| } else if (resolvedType instanceof UnknownType || (resolvedType instanceof ObjectType objectType && objectType.type() instanceof UnknownType)) { | ||
| if (aliasedName.alias() != null) { | ||
| var unresolvedImportType = new UnresolvedImportType(String.join(".", fqn)); |
There was a problem hiding this comment.
For this prototype/investigation, it doesn't matter, but when we actually implement this we should probably try to ensure we don't create duplicate types for the same FQN if we see stuff like:
def foo():
from lib import some_func
def bar():
from lib import some_func
|
This pull request introduces a new
UnresolvedImportTypeto handle unknown imports in Python files and updates the type inference logic accordingly. Additionally, it includes several test updates to verify the new behavior.Type Inference Enhancements:
UnresolvedImportTypeclass to handle unresolved imports. (python-frontend/src/main/java/org/sonar/python/types/v2/UnresolvedImportType.java)TrivialTypeInferenceVisitorto setUnresolvedImportTypefor unknown imports. (python-frontend/src/main/java/org/sonar/python/semantic/v2/types/TrivialTypeInferenceVisitor.java) [1] [2] [3] [4]Test Updates:
UnresolvedImportTypebehavior. (python-frontend/src/test/java/org/sonar/python/semantic/v2/TypeInferenceV2Test.java) [1] [2] [3]Assertions.assertThatwithassertThatfor consistency. (python-frontend/src/test/java/org/sonar/python/semantic/v2/TypeInferenceV2Test.java) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19]