SONARHTML-198 Create rule S6852: Elements with an interactive role should support focus #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yassin-kammoun-sonarsource
force-pushed
the
SONARHTML-198
branch
4 times, most recently
from
75da7cb to
7968028
Compare
…ould support focus
yassin-kammoun-sonarsource
force-pushed
the
SONARHTML-198
branch
from
7968028 to
49e25e3
Compare
Comment on lines
72
to
101
| private static boolean isHTMLTag(TagNode element) { | ||
| return KNOWN_HTML_TAGS.stream().anyMatch(tag -> tag.equalsIgnoreCase(element.getNodeName())); | ||
| } | ||
|
|
||
| private static boolean hasInteractiveProps(TagNode element) { | ||
| return INTERACTIVE_PROPS.stream().anyMatch(prop -> { | ||
| var attr = element.getAttribute(prop); | ||
| return attr != null && !attr.isEmpty(); | ||
| }); | ||
| } | ||
|
|
||
| private static boolean hasInteractiveRole(TagNode element) { | ||
| return INTERACTIVE_ROLES.stream().anyMatch(role -> role.equalsIgnoreCase(element.getAttribute("role"))); | ||
| } | ||
|
|
||
| private static boolean isInteractiveElement(TagNode element) { | ||
| return INTERACTIVE_ELEMENTS.stream().anyMatch(tag -> tag.equalsIgnoreCase(element.getNodeName())); | ||
| } | ||
|
|
||
| private static boolean isNoninteractiveElement(TagNode element) { | ||
| return NON_INTERACTIVE_ELEMENTS.stream().anyMatch(tag -> tag.equalsIgnoreCase(element.getNodeName())); | ||
| } | ||
|
|
||
| private static boolean hasPresentationRole(TagNode element) { | ||
| return PRESENTATION_ROLES.stream().anyMatch(role -> role.equalsIgnoreCase(element.getAttribute("role"))); | ||
| } | ||
|
|
||
| private static boolean hasNoninteractiveRole(TagNode element) { | ||
| return NON_INTERACTIVE_ROLES.stream().anyMatch(role -> role.equalsIgnoreCase(element.getAttribute("role"))); | ||
| } |
There was a problem hiding this comment.
could you refactor this to use the methods from HtmlConstants.java, and move the new ones there?
There was a problem hiding this comment.
👍
ilia-kebets-sonarsource
approved these changes
Feb 22, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.