Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S6840: DOM elements should use the "autocomplete" attribute correctly #278

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

ericmorand-sonarsource
Copy link
Contributor

No description provided.

@ericmorand-sonarsource ericmorand-sonarsource force-pushed the SONARHTML-197 branch 2 times, most recently from 1e428a4 to 71c3601 Compare February 21, 2024 08:49
DOM elements should use the "autocomplete" attribute correctly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left minor suggestions here and there for you to address, but you are free to ignore any of them that you think are not worth the trouble.

Outstanding job!

Copy link

sonarqube-next bot commented Feb 21, 2024

@ericmorand-sonarsource
Copy link
Contributor Author

@yassin-kammoun-sonarsource all issues have been fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericmorand-sonarsource ericmorand-sonarsource merged commit 3f1d061 into master Feb 21, 2024
8 checks passed
@ericmorand-sonarsource ericmorand-sonarsource deleted the SONARHTML-197 branch February 21, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants