-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create rule S6840: DOM elements should use the "autocomplete" attribute correctly #278
Conversation
1e428a4
to
71c3601
Compare
DOM elements should use the "autocomplete" attribute correctly
71c3601
to
21d83a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left minor suggestions here and there for you to address, but you are free to ignore any of them that you think are not worth the trouble.
Outstanding job!
sonar-html-plugin/src/main/java/org/sonar/plugins/html/api/HtmlConstants.java
Outdated
Show resolved
Hide resolved
...ugins/html/checks/accessibility/DomElementsShouldUseAutocompleteAttributeCorrectlyCheck.java
Outdated
Show resolved
Hide resolved
...ugins/html/checks/accessibility/DomElementsShouldUseAutocompleteAttributeCorrectlyCheck.java
Outdated
Show resolved
Hide resolved
...ugins/html/checks/accessibility/DomElementsShouldUseAutocompleteAttributeCorrectlyCheck.java
Outdated
Show resolved
Hide resolved
...ugins/html/checks/accessibility/DomElementsShouldUseAutocompleteAttributeCorrectlyCheck.java
Outdated
Show resolved
Hide resolved
sonar-html-plugin/src/main/java/org/sonar/plugins/html/api/accessibility/ControlGroup.java
Outdated
Show resolved
Hide resolved
sonar-html-plugin/src/main/java/org/sonar/plugins/html/api/accessibility/ControlGroup.java
Outdated
Show resolved
Hide resolved
sonar-html-plugin/src/main/java/org/sonar/plugins/html/api/accessibility/ControlGroup.java
Outdated
Show resolved
Hide resolved
...ugins/html/checks/accessibility/DomElementsShouldUseAutocompleteAttributeCorrectlyCheck.java
Outdated
Show resolved
Hide resolved
sonar-html-plugin/src/main/java/org/sonar/plugins/html/api/accessibility/ControlGroup.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
@yassin-kammoun-sonarsource all issues have been fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.