Fix S6846: location on tag name was 1 column too far #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ilia-kebets-sonarsource
commented
Feb 16, 2024
ilia-kebets-sonarsource
commented
|
yassin-kammoun-sonarsource
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Looks good to me, but to be honest, I wonder whether we should avoid doing this kind of error-prone arithmetic and keep raising on nodes and lines just like the other rules do for now.
For me, it would make more sense to plan a different sprint and invest in improving the analyzer API for better issue reporting (and maybe quickfixes). Then we could come back to each implemented rule and improve reported issue locations.
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.