-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SONARHTML-207 Create rule S6827: Anchors should contain accessible content #267
Conversation
4d5edec
to
3846188
Compare
3846188
to
293cd79
Compare
...lugin/src/main/java/org/sonar/plugins/html/checks/accessibility/AnchorsHaveContentCheck.java
Show resolved
Hide resolved
...lugin/src/main/java/org/sonar/plugins/html/checks/accessibility/AnchorsHaveContentCheck.java
Outdated
Show resolved
Hide resolved
Why not capture the following cases: <a />
<a><Bar aria-hidden /></a> <!--this one will need to be adapted to something that exists in HTML> I tested all from https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/__tests__/src/rules/anchor-has-content-test.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comment, otherwise LGTM!
I am not sure about |
Quality Gate passedIssues Measures |
Inspired from anchor-has-content