-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix S3247 FN: Support structs #9479
Conversation
690e7c1
to
9e4820f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I left some educational questions.
analyzers/its/expected/akka.net/S3247-Akka.Tests.Shared.Internals-netstandard2.0.json
Show resolved
Hide resolved
a8a9bcf
to
6b74980
Compare
6b74980
to
85c6770
Compare
Quality Gate passed for 'Sonar .NET Java Plugin'Issues Measures |
Quality Gate passed for 'SonarAnalyzer for .NET'Issues Measures |
@sebastien-marichal Please take one more look. I've added one more commit, because I've noticed one more place with struct filter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Part of #223