Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3247 FN: Support structs #9479

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Conversation

pavel-mikula-sonarsource
Copy link
Contributor

Part of #223

Copy link
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I left some educational questions.

Base automatically changed from Pavel/S3247-Cleanup to master June 27, 2024 13:35
Copy link

sonarcloud bot commented Jun 27, 2024

Copy link

sonarcloud bot commented Jun 27, 2024

@pavel-mikula-sonarsource
Copy link
Contributor Author

@sebastien-marichal Please take one more look. I've added one more commit, because I've noticed one more place with struct filter

Copy link
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sebastien-marichal sebastien-marichal merged commit 6c22ef8 into master Jun 28, 2024
30 checks passed
@sebastien-marichal sebastien-marichal deleted the Pavel/S3247-01-Struct branch June 28, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprint: Hardening Fix FPs/FNs/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants