Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3247 cleanup #9478

Merged
merged 3 commits into from
Jun 27, 2024
Merged

S3247 cleanup #9478

merged 3 commits into from
Jun 27, 2024

Conversation

pavel-mikula-sonarsource
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource commented Jun 27, 2024

Preparation for #223

Review per commit will be easier due to file-scoped namespaces

Those uncovered cases are not coverable. Roslyn is introducing fake intermediate nodes into the tree for the switch labels and arms to work.

Copy link

sonarcloud bot commented Jun 27, 2024

Copy link

sonarcloud bot commented Jun 27, 2024

Quality Gate Failed Quality Gate failed for 'SonarAnalyzer for .NET'

Failed conditions
90.0% Coverage on New Code (required ≥ 95%)

See analysis details on SonarCloud

Copy link
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit df86e7f into master Jun 27, 2024
28 of 29 checks passed
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Pavel/S3247-Cleanup branch June 27, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprint: Hardening Fix FPs/FNs/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants