S1854: Add FP repro for #9471, #9472, #9473 #9474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned mary-georgiou-sonarsource
pavel-mikula-sonarsource
requested changes
Jun 26, 2024
There was a problem hiding this comment.
Once #9469 gets merged, you could move the methods into the class I added (there's less nesting, as my class is not in the useless namespace)
| // https://github.com/SonarSource/sonar-dotnet/issues/9471 | ||
| void Repro9471(bool condition) | ||
| { | ||
| byte[]? tempArray = null; |
There was a problem hiding this comment.
Do we need byte[]? to complicate this case, or would string be enough? This is not nullable codebase anyway
There was a problem hiding this comment.
I meant string instead of string[]. To get rid of the array, and nullability
analyzers/tests/SonarAnalyzer.Test/TestCases/DeadStores.RoslynCfg.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/TestCases/DeadStores.RoslynCfg.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned pavel-mikula-sonarsource
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned mary-georgiou-sonarsource
pavel-mikula-sonarsource
added
Sprint: Hardening
mary-georgiou-sonarsource
force-pushed
the
mary/repros
branch
from
a526121
to
8f95770
Compare
pavel-mikula-sonarsource
approved these changes
Jun 27, 2024
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned pavel-mikula-sonarsource
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #9471, #9472, #9473