Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S1854 FP: Value used in catch or when should LiveIn for all try blocks #9449

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

pavel-mikula-sonarsource
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource commented Jun 20, 2024

Fixes #9447
Fixes #8719

The FP is not visible in this PR, because it's muted by the rule, see #4940

Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from Pavel/LVA-Finally to master June 20, 2024 19:37
Copy link

sonarcloud bot commented Jun 20, 2024

Copy link

sonarcloud bot commented Jun 20, 2024

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit cc797dd into master Jun 20, 2024
26 checks passed
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Pavel/LVA-Catch branch June 20, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants