Fix S2187: Rule should not raise an issue when class is abstract #930

Evangelink · 2017-11-13T17:02:26Z

michalb-sonar

I'd still report if abstract class with attribute has no derived classes.

michalb-sonar · 2017-11-14T09:33:36Z

sonaranalyzer-dotnet/src/SonarAnalyzer.CSharp/Rules/TestClassShouldHaveTestMethod.cs

                    if (classSymbol == null ||
-                        !classSymbol.GetAttributes().Any(a => a.AttributeClass.IsAny(HandledTestClassAttributes)))
+                        !classSymbol.GetAttributes().Any(a => a.AttributeClass.IsAny(HandledTestClassAttributes)) ||


Move IsAbstract check before the attribute check. Hey, am I suggesting micro-performace tweak? :)

Fix S2187: Rule should not raise an issue when class is abstract

7a56a5f

Evangelink requested review from duncanp-sonar, michalb-sonar and valhristov as code owners November 13, 2017 17:02

ghost assigned Evangelink Nov 13, 2017

Evangelink added the Status: Needs Review label Nov 13, 2017

michalb-sonar approved these changes Nov 14, 2017

View reviewed changes

Address review comment

e28a1eb

Evangelink merged commit 6f70b5e into master Nov 14, 2017

Evangelink deleted the ammo/fix-#929 branch November 14, 2017 10:09

ghost removed the Status: Needs Review label Nov 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix S2187: Rule should not raise an issue when class is abstract #930

Fix S2187: Rule should not raise an issue when class is abstract #930

Evangelink commented Nov 13, 2017 •

edited

Loading

michalb-sonar left a comment

michalb-sonar Nov 14, 2017

Fix S2187: Rule should not raise an issue when class is abstract #930

Fix S2187: Rule should not raise an issue when class is abstract #930

Conversation

Evangelink commented Nov 13, 2017 • edited Loading

michalb-sonar left a comment

Choose a reason for hiding this comment

michalb-sonar Nov 14, 2017

Choose a reason for hiding this comment

Evangelink commented Nov 13, 2017 •

edited

Loading