Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rule types #847

Merged
merged 6 commits into from
Oct 19, 2017
Merged

Update rule types #847

merged 6 commits into from
Oct 19, 2017

Conversation

valhristov
Copy link
Contributor

@valhristov valhristov commented Oct 18, 2017 •
edited
Loading

Fix #839, Fix #840, Fix #841, Fix #842, Fix #843, Fix #844

@valhristov valhristov changed the title Update rule types [AFTER RELEASE] Update rule types Oct 18, 2017
@valhristov valhristov changed the title [AFTER RELEASE] Update rule types [MERGE AFTER RELEASE] Update rule types Oct 18, 2017
Evangelink
Evangelink approved these changes Oct 18, 2017
View reviewed changes
Copy link
Contributor

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Evangelink Evangelink changed the base branch from master to temp-master October 19, 2017 10:12
@Evangelink Evangelink changed the title [MERGE AFTER RELEASE] Update rule types Update rule types Oct 19, 2017
@valhristov valhristov merged commit 5ec7cee into temp-master Oct 19, 2017
@valhristov valhristov deleted the valeri/rspec branch October 19, 2017 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

@duncanp-sonar duncanp-sonar Awaiting requested review from duncanp-sonar

@michalb-sonar michalb-sonar Awaiting requested review from michalb-sonar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valhristov @Evangelink