Fix S3346: Rule should look for blacklist only on begining of the inv… #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michalb-sonar Could you review PR title? I am waiting for review on the RSPEC then I will update the metadata. |
michalb-sonar
suggested changes
Jul 20, 2017
| @@ -3,6 +3,10 @@ | |||
| <p>In non-debug mode, all <code>Debug.Assert</code> are automatically left out. So, by contract, the boolean expressions that are evaluated by those | |||
| assertions must absolutely not contain any side effects. Otherwise, when leaving the Debug mode, the functional behavior of the application is not the | |||
| same anymore.</p> | |||
| <p>The rule will raise if the method name starts with any of the following <code>remove</code>, <code>delete</code>, <code>add</code>, | |||
| <code>pop</code>, <code>update</code>, <code>retain</code>, <code>insert</code>, <code>push</code>, <code>append</code>, <code>clear</code>, | |||
| <code>dequeue</code>, <code>enqueue</code>, <code>dispose</code>, <code>put</code>, or <code>set</code>, although <code>SetEquals</code> will be | |||
There was a problem hiding this comment.
[optional] Instead of adding it at the end of the sentence, I'd add an exception paragraph, as we do usually - it would stand out more.
|
|
||
| <!-- | ||
| Microsoft ResX Schema | ||
There was a problem hiding this comment.
Space attack! Are they generated by the script only when updating rule?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ocation
Fix #547