Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overloads with a 'CultureInfo' or an 'IFormatProvider' parameter shou… #540

Merged
merged 1 commit into from
Jul 6, 2017
Merged

Overloads with a 'CultureInfo' or an 'IFormatProvider' parameter shou… #540

merged 1 commit into from
Jul 6, 2017
+15,931 −28

Conversation

Evangelink
Copy link
Contributor

…ld be used

Fix #513

valhristov
valhristov approved these changes Jul 6, 2017
View reviewed changes
Copy link
Contributor

@valhristov valhristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, noisy rule... as expected :)

@Evangelink Evangelink merged commit 24eef9a into master Jul 6, 2017
@Evangelink Evangelink deleted the rule-S4056 branch July 6, 2017 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valhristov valhristov valhristov approved these changes

@michalb-sonar michalb-sonar Awaiting requested review from michalb-sonar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Evangelink @valhristov