Update S2328: "GetHashCode should not reference mutable fields" should report once per method #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 9, 2017 14:33
valhristov
approved these changes
Jun 9, 2017
|
|
||
| var secondaryLocations = GetAllFirstMutableFieldsUsed(c, fieldsOfClass, identifiers) | ||
| .Select(identifierSyntax => new SecondaryLocation(identifierSyntax.GetLocation(), | ||
| string.Format(SecondaryMessageFormat, identifierSyntax.Identifier.Text))) |
There was a problem hiding this comment.
This Select is a bit ugly and could be extracted into a method...
| { | ||
| return; | ||
| } | ||
|
|
||
| var semanticModel = await context.Document.GetSemanticModelAsync(context.CancellationToken).ConfigureAwait(false); | ||
| var allFieldDeclarationTasks = identifiersToFix.Select(identifier => GetFieldDeclarationSyntax(semanticModel, identifier, context.CancellationToken)); |
There was a problem hiding this comment.
We should reduce our "line too long" rule limit to 130 chars. GitHub is showing scrollbar for longer lines...
michalb-sonar
approved these changes
Jun 9, 2017
| return line; | ||
| } | ||
|
|
||
| if (match.Groups["issueType"].Value.Equals("Noncompliant")) |
There was a problem hiding this comment.
Change to:
match.Groups["issueType"].Value == "Noncompliant"
| @@ -50,7 +50,8 @@ public static bool IsObjectEquals(this IMethodSymbol methodSymbol) | |||
|
|
|||
| public static bool IsObjectGetHashCode(this IMethodSymbol methodSymbol) | |||
| { | |||
| return methodSymbol.IsOverride && | |||
| return methodSymbol != null && | |||
There was a problem hiding this comment.
Good idea. We should do it for all other methods in this class.
There was a problem hiding this comment.
@michalb-sonar Yes I think so too but this refactoring doesn't belong to this PR that's why I haven't done it yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #346.