Fix S1144: False Positive when private member is only used in a gener… #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Evangelink
commented
Mar 6, 2019
| @@ -85,7 +85,7 @@ protected override void Initialize(SonarAnalysisContext context) | |||
| // Collect symbols of private members that could potentially be removed | |||
| var removableSymbolsCollector = new CSharpRemovableSymbolWalker(c.Compilation.GetSemanticModel); | |||
|
|
|||
| if (!VisitDeclaringReferences(namedType, removableSymbolsCollector, c.Compilation)) | |||
| if (!VisitDeclaringReferences(namedType, removableSymbolsCollector, c.Compilation, includeGeneratedFile: false)) | |||
There was a problem hiding this comment.
We don't need to collect the members declared in generated files as we don't want to report about them...
| @@ -100,7 +100,7 @@ protected override void Initialize(SonarAnalysisContext context) | |||
| c.Compilation.GetSemanticModel, | |||
| removableSymbolsCollector.PrivateSymbols.Select(s => s.Name).ToHashSet()); | |||
|
|
|||
| if (!VisitDeclaringReferences(namedType, usageCollector, c.Compilation)) | |||
| if (!VisitDeclaringReferences(namedType, usageCollector, c.Compilation, includeGeneratedFile: true)) | |||
There was a problem hiding this comment.
... But we do want to collect the usages of other members even in generated files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ated file
Fix #2312