Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule S1125: Boolean literals should not be redundant #2267

Merged
merged 8 commits into from
Feb 7, 2019
Merged

Rule S1125: Boolean literals should not be redundant #2267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
269c82d
S1125 - VB implementation and more CS tests
andrei-epure-sonarsource Feb 1, 2019
436c045
CS refactor: Use simple SyntaxKind check
andrei-epure-sonarsource Feb 5, 2019
72cb73b
Factorize to base class
andrei-epure-sonarsource Feb 6, 2019
eea50c1
Add IT results
andrei-epure-sonarsource Feb 6, 2019
692b2ea
Move CheckConditional to base impl
andrei-epure-sonarsource Feb 6, 2019
94eb46c
address CR comments
andrei-epure-sonarsource Feb 7, 2019
bd5d123
fix CR comments
andrei-epure-sonarsource Feb 7, 2019
c9d9588
use delegate instead of IsKind+getters
andrei-epure-sonarsource Feb 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
368 changes: 368 additions & 0 deletions ...s/expected/Ember-MM/Ember Media Manager-{9B57D3AB-AF12-4012-B945-284C2448DC81}-S1125.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,368 @@
{
"issues": [
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\dlgFileInfo.vb",
"region": {
"startLine": 83,
"startColumn": 50,
"endLine": 83,
"endColumn": 56
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\dlgFileInfo.vb",
"region": {
"startLine": 142,
"startColumn": 42,
"endLine": 142,
"endColumn": 48
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\dlgFileInfo.vb",
"region": {
"startLine": 192,
"startColumn": 50,
"endLine": 192,
"endColumn": 56
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\dlgManualEdit.vb",
"region": {
"startLine": 89,
"startColumn": 20,
"endLine": 89,
"endColumn": 26
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\dlgManualEdit.vb",
"region": {
"startLine": 259,
"startColumn": 24,
"endLine": 259,
"endColumn": 29
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\dlgManualEdit.vb",
"region": {
"startLine": 376,
"startColumn": 22,
"endLine": 376,
"endColumn": 27
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 4203,
"startColumn": 90,
"endLine": 4203,
"endColumn": 95
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 5526,
"startColumn": 33,
"endLine": 5526,
"endColumn": 39
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 5569,
"startColumn": 72,
"endLine": 5569,
"endColumn": 83
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 5789,
"startColumn": 131,
"endLine": 5789,
"endColumn": 136
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 6481,
"startColumn": 37,
"endLine": 6481,
"endColumn": 43
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 6882,
"startColumn": 117,
"endLine": 6882,
"endColumn": 128
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 6883,
"startColumn": 117,
"endLine": 6883,
"endColumn": 128
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 6884,
"startColumn": 119,
"endLine": 6884,
"endColumn": 130
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 6888,
"startColumn": 108,
"endLine": 6888,
"endColumn": 119
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 6889,
"startColumn": 108,
"endLine": 6889,
"endColumn": 119
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 6890,
"startColumn": 110,
"endLine": 6890,
"endColumn": 121
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 7107,
"startColumn": 124,
"endLine": 7107,
"endColumn": 135
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 7109,
"startColumn": 128,
"endLine": 7109,
"endColumn": 139
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 7113,
"startColumn": 115,
"endLine": 7113,
"endColumn": 126
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 7115,
"startColumn": 119,
"endLine": 7115,
"endColumn": 130
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 7194,
"startColumn": 117,
"endLine": 7194,
"endColumn": 128
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 7195,
"startColumn": 117,
"endLine": 7195,
"endColumn": 128
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 7196,
"startColumn": 121,
"endLine": 7196,
"endColumn": 132
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 7200,
"startColumn": 108,
"endLine": 7200,
"endColumn": 119
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 7201,
"startColumn": 108,
"endLine": 7201,
"endColumn": 119
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 7202,
"startColumn": 112,
"endLine": 7202,
"endColumn": 123
}
}
},
{
"id": "S1125",
"message": "Remove the unnecessary Boolean literal(s).",
"location": {
"uri": "sources\Ember-MM\Ember%20Media%20Manager\frmMain.vb",
"region": {
"startLine": 7728,
"startColumn": 64,
"endLine": 7728,
"endColumn": 76
}
}
}
]
}
Loading