Rule S2234: Parameters should be passed in the correct order #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Evangelink
commented
Feb 5, 2019
| using Microsoft.CodeAnalysis; | ||
| using Microsoft.CodeAnalysis.CSharp.Syntax; | ||
|
|
||
| namespace SonarAnalyzer.Helpers | ||
| { | ||
| // todo: this should come from the Roslyn API (https://github.com/dotnet/roslyn/issues/9) | ||
| internal class CSharpMethodParameterLookup | ||
| internal class CSharpMethodParameterLookup : AbstractMethodParameterLookup<ArgumentSyntax> |
There was a problem hiding this comment.
Most of the code has been extracted and factorized in a base class.
andrei-epure-sonarsource
requested changes
Feb 6, 2019
sonaranalyzer-dotnet/src/SonarAnalyzer.VisualBasic/Rules/ParametersCorrectOrder.cs
Show resolved
Hide resolved
|
|
||
| var memberAccess = methodCall.Expression as MemberAccessExpressionSyntax; | ||
| Location getLocation() => | ||
| memberAccess == null |
There was a problem hiding this comment.
partial test coverage
| { | ||
| if (argumentList == null) | ||
| { | ||
| return; |
There was a problem hiding this comment.
not covered by tests (is it possible?)
sonaranalyzer-dotnet/src/SonarAnalyzer.VisualBasic/Rules/MethodsShouldNotHaveTooManyLines.cs
Show resolved
Hide resolved
sonaranalyzer-dotnet/tests/SonarAnalyzer.UnitTest/TestCases/ParametersCorrectOrder.vb
Outdated
Show resolved
Hide resolved
sonaranalyzer-dotnet/src/SonarAnalyzer.Common/Rules/ParametersCorrectOrderBase.cs
Outdated
Show resolved
Hide resolved
sonaranalyzer-dotnet/src/SonarAnalyzer.Common/Rules/ParametersCorrectOrderBase.cs
Outdated
Show resolved
Hide resolved
sonaranalyzer-dotnet/src/SonarAnalyzer.VisualBasic/Helpers/VisualBasicMethodParameterLookup.cs
Outdated
Show resolved
Hide resolved
sonaranalyzer-dotnet/src/SonarAnalyzer.Common/Helpers/AbstractMethodParameterLookup.cs
Outdated
Show resolved
Hide resolved
sonaranalyzer-dotnet/src/SonarAnalyzer.CSharp/Rules/RedundantArgumentCodeFixProvider.cs
Show resolved
Hide resolved
Evangelink
force-pushed
the
ammo/S2234
branch
from
fcce650
to
a9917ab
Compare
andrei-epure-sonarsource
requested changes
Feb 6, 2019
sonaranalyzer-dotnet/src/SonarAnalyzer.Common/Rules/ParametersCorrectOrderBase.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2055