Fix S1144: Do not keep references to all type symbols #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
valhristov
commented
Jan 3, 2019
| { | ||
| Verifier.VerifyCSharpAnalyzer(@" | ||
| [assembly: System.Reflection.AssemblyCompany(Foo.Constants.AppCompany)] | ||
| public static class Foo | ||
| { | ||
| internal static class Constants // Noncompliant, False Positive; we cannot detect usages from assembly level attributes. | ||
| internal static class Constants // Compliant, detect usages from assembly level attributes. |
There was a problem hiding this comment.
We can now detect internal members used in assembly-level attributes because in the second pass we analyze all whole syntax trees in the compilation, not just the class declarations
Evangelink
approved these changes
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2203, Fix #2154
Note
I did not go with the additional optimizations because reporting for property accessors would become much more difficult.