Fix S4275 FP: Support &= assignment

[keith-softsure]

SonarLint does not recognise &= operator as assignment

S4275 fails the SET statement and suggests that _feedback parameter is not assigned a value in this line:
_feedback &= value

Repro steps

Friend Property Feedback As String
    Get
        Return _feedback
    End Get
    Private Set(value As String)
        value = Trim(value).Trim()
        Debug.Print(value)
        If _feedback <> Nothing Then _feedback &= vbCrLf
        _feedback &= value ' original Code
        ' _feedback = _feedback & value ' SonarLint compliant code
    End Set
End Property
Private _feedback As String

Expected behavior

_feedback &= value ' original Code
should be acceptable

Actual behavior

_feedback &= value ' original Code
generates S4275 error

Known workarounds

   _feedback = _feedback & value ' SonarLint compliant code

Related information

• C#/VB.NET Plugins version ... 8.5.0.10497
• Visual Studio version ... 17.11.5
• MSBuild / dotnet version ... 4.8.09037
• Using SonarLint & Sonar Cloud
• Operating System ... Windows 10

[CristianAmbrosini]

Hi @keith-softsure! I confirm this as a false positive. I'll add a reproducer to our repository shortly. Thanks for the feedback!

[keith-softsure]

Thanks Cristian, We really appreciate the feedback. And your good work. Cheers Keith From: Cristian ***@***.***> Sent: Wed, 30 October 2024 12:17 To: SonarSource/sonar-dotnet ***@***.***> Cc: Keith Shearer ***@***.***>; Mention ***@***.***> Subject: Re: [SonarSource/sonar-dotnet] Fix S4275 FP: Support &= assignment (Issue #9688) This message originates from outside the Badger Holdings Organization, please exercise caution

…

________________________________ Hi @keith-softsure<https://github.com/keith-softsure>! I confirm this as a false positive. I'll add a reproducer to our repository shortly. Thanks for the feedback! - Reply to this email directly, view it on GitHub<#9688 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BH7ROGMIQASE7EHXYKNUP4LZ6CW23AVCNFSM6AAAAABQQJHYU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBWGQ2TOMRVHA>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>