-
Notifications
You must be signed in to change notification settings - Fork 227
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
…720)
- Loading branch information
1 parent
feb4016
commit ffd6451
Showing
12 changed files
with
5,575 additions
and
0 deletions.
There are no files selected for viewing
30 changes: 30 additions & 0 deletions
30
.../its/expected/Nancy/Nancy.Testing.Tests-{8EB9E15A-4B65-4C80-B834-9A7773750666}-S2701.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| { | ||
| "issues": [ | ||
| { | ||
| "id": "S2701", | ||
| "message": "Remove or correct this assertion.", | ||
| "location": { | ||
| "uri": "sources\Nancy\src\Nancy.Testing.Tests\BrowserFixture.cs", | ||
| "region": { | ||
| "startLine": 462, | ||
| "startColumn": 13, | ||
| "endLine": 462, | ||
| "endColumn": 56 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "S2701", | ||
| "message": "Remove or correct this assertion.", | ||
| "location": { | ||
| "uri": "sources\Nancy\src\Nancy.Testing.Tests\BrowserFixture.cs", | ||
| "region": { | ||
| "startLine": 484, | ||
| "startColumn": 13, | ||
| "endLine": 484, | ||
| "endColumn": 56 | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } |
30 changes: 30 additions & 0 deletions
30
...s/expected/Nancy/Nancy.Tests.Functional-{BDA5E175-07D7-4E6F-B46F-C2CF7D63E231}-S2701.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| { | ||
| "issues": [ | ||
| { | ||
| "id": "S2701", | ||
| "message": "Remove or correct this assertion.", | ||
| "location": { | ||
| "uri": "sources\Nancy\src\Nancy.Tests.Functional\Tests\SerializeTests.cs", | ||
| "region": { | ||
| "startLine": 44, | ||
| "startColumn": 13, | ||
| "endLine": 44, | ||
| "endColumn": 56 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "S2701", | ||
| "message": "Remove or correct this assertion.", | ||
| "location": { | ||
| "uri": "sources\Nancy\src\Nancy.Tests.Functional\Tests\SerializeTests.cs", | ||
| "region": { | ||
| "startLine": 66, | ||
| "startColumn": 13, | ||
| "endLine": 66, | ||
| "endColumn": 56 | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } |
30 changes: 30 additions & 0 deletions
30
...ts/expected/akka.net/Akka.Cluster.Tests-{C8D6A95C-50BF-4416-A212-86B18B87220D}-S2701.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| { | ||
| "issues": [ | ||
| { | ||
| "id": "S2701", | ||
| "message": "Remove or correct this assertion.", | ||
| "location": { | ||
| "uri": "sources\akka.net\src\core\Akka.Cluster.Tests\MetricsCollectorSpec.cs", | ||
| "region": { | ||
| "startLine": 57, | ||
| "startColumn": 25, | ||
| "endLine": 57, | ||
| "endColumn": 82 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "S2701", | ||
| "message": "Remove or correct this assertion.", | ||
| "location": { | ||
| "uri": "sources\akka.net\src\core\Akka.Cluster.Tests\MetricsCollectorSpec.cs", | ||
| "region": { | ||
| "startLine": 75, | ||
| "startColumn": 25, | ||
| "endLine": 75, | ||
| "endColumn": 82 | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } |
134 changes: 134 additions & 0 deletions
134
...dotnet/its/expected/akka.net/Akka.Tests-{3F786C7D-70E3-4836-8B33-EC9A5AF72330}-S2701.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,134 @@ | ||
| { | ||
| "issues": [ | ||
| { | ||
| "id": "S2701", | ||
| "message": "Remove or correct this assertion.", | ||
| "location": { | ||
| "uri": "sources\akka.net\src\core\Akka.Tests\Configuration\ConfigurationSpec.cs", | ||
| "region": { | ||
| "startLine": 43, | ||
| "startColumn": 13, | ||
| "endLine": 43, | ||
| "endColumn": 66 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "S2701", | ||
| "message": "Remove or correct this assertion.", | ||
| "location": { | ||
| "uri": "sources\akka.net\src\core\Akka.Tests\Configuration\HoconTests.cs", | ||
| "region": { | ||
| "startLine": 119, | ||
| "startColumn": 13, | ||
| "endLine": 119, | ||
| "endColumn": 60 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "S2701", | ||
| "message": "Remove or correct this assertion.", | ||
| "location": { | ||
| "uri": "sources\akka.net\src\core\Akka.Tests\Configuration\HoconTests.cs", | ||
| "region": { | ||
| "startLine": 152, | ||
| "startColumn": 13, | ||
| "endLine": 152, | ||
| "endColumn": 63 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "S2701", | ||
| "message": "Remove or correct this assertion.", | ||
| "location": { | ||
| "uri": "sources\akka.net\src\core\Akka.Tests\Configuration\HoconTests.cs", | ||
| "region": { | ||
| "startLine": 153, | ||
| "startColumn": 13, | ||
| "endLine": 153, | ||
| "endColumn": 76 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "S2701", | ||
| "message": "Remove or correct this assertion.", | ||
| "location": { | ||
| "uri": "sources\akka.net\src\core\Akka.Tests\Configuration\HoconTests.cs", | ||
| "region": { | ||
| "startLine": 187, | ||
| "startColumn": 13, | ||
| "endLine": 187, | ||
| "endColumn": 63 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "S2701", | ||
| "message": "Remove or correct this assertion.", | ||
| "location": { | ||
| "uri": "sources\akka.net\src\core\Akka.Tests\Configuration\HoconTests.cs", | ||
| "region": { | ||
| "startLine": 188, | ||
| "startColumn": 13, | ||
| "endLine": 188, | ||
| "endColumn": 76 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "S2701", | ||
| "message": "Remove or correct this assertion.", | ||
| "location": { | ||
| "uri": "sources\akka.net\src\core\Akka.Tests\Configuration\HoconTests.cs", | ||
| "region": { | ||
| "startLine": 358, | ||
| "startColumn": 13, | ||
| "endLine": 358, | ||
| "endColumn": 88 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "S2701", | ||
| "message": "Remove or correct this assertion.", | ||
| "location": { | ||
| "uri": "sources\akka.net\src\core\Akka.Tests\Configuration\HoconTests.cs", | ||
| "region": { | ||
| "startLine": 360, | ||
| "startColumn": 13, | ||
| "endLine": 360, | ||
| "endColumn": 89 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "S2701", | ||
| "message": "Remove or correct this assertion.", | ||
| "location": { | ||
| "uri": "sources\akka.net\src\core\Akka.Tests\Configuration\HoconTests.cs", | ||
| "region": { | ||
| "startLine": 363, | ||
| "startColumn": 13, | ||
| "endLine": 363, | ||
| "endColumn": 88 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "S2701", | ||
| "message": "Remove or correct this assertion.", | ||
| "location": { | ||
| "uri": "sources\akka.net\src\core\Akka.Tests\Configuration\HoconTests.cs", | ||
| "region": { | ||
| "startLine": 365, | ||
| "startColumn": 13, | ||
| "endLine": 365, | ||
| "endColumn": 89 | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <p>There's no reason to use literal boolean values in assertions. Doing so is at best confusing for maintainers, and at worst a bug.</p> | ||
| <h2>Noncompliant Code Example</h2> | ||
| <pre> | ||
| bool b = true; | ||
| NUnit.Framework.Assert.AreEqual(true, b); | ||
| Xunit.Assert.NotSame(true, b); | ||
| Microsoft.VisualStudio.TestTools.UnitTesting.Assert.AreEqual(true, b); | ||
| System.Diagnostics.Debug.Assert(true); | ||
| </pre> | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "title": "Literal boolean values should not be used in assertions", | ||
| "type": "CODE_SMELL", | ||
| "status": "ready", | ||
| "remediation": { | ||
| "func": "Constant\/Issue", | ||
| "constantCost": "5min" | ||
| }, | ||
| "tags": [ | ||
| "tests" | ||
| ], | ||
| "defaultSeverity": "Critical" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.