Fix FunctionComplexity to not throw an exception on Lucene.Net

SonarSource · Aug 31, 2017 · f389d0b · f389d0b
1 parent f197635
commit f389d0b
Show file tree

Hide file tree

Showing 6 changed files with 1,535 additions and 6 deletions.
diff --git a/sonaranalyzer-dotnet/src/SonarAnalyzer.CSharp/Helpers/CyclomaticComplexityWalker.cs b/sonaranalyzer-dotnet/src/SonarAnalyzer.CSharp/Helpers/CyclomaticComplexityWalker.cs
@@ -18,6 +18,7 @@
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using Microsoft.CodeAnalysis;
@@ -35,6 +36,21 @@ public class CyclomaticComplexityWalker : CSharpSyntaxWalker
 
         public int CyclomaticComplexity => incrementLocations.Count;
 
+        public void Walk(SyntaxNode node)
+        {
+            try
+            {
+                Visit(node);
+            }
+            catch (InsufficientExecutionStackException)
+            {
+                // TODO: trace this exception
+
+                // Roslyn walker overflows the stack when the depth of the call is around 2050.
+                // See ticket #727.
+            }
+        }
+
         public override void VisitMethodDeclaration(MethodDeclarationSyntax node)
         {
             if (node.ExpressionBody != null || HasBody(node))

diff --git a/sonaranalyzer-dotnet/src/SonarAnalyzer.CSharp/Metrics/Metrics.cs b/sonaranalyzer-dotnet/src/SonarAnalyzer.CSharp/Metrics/Metrics.cs
@@ -144,7 +144,7 @@ protected override IEnumerable<SyntaxNode> PublicApiNodes
         public override int GetComplexity(SyntaxNode node)
         {
             var walker = new CyclomaticComplexityWalker();
-            walker.Visit(node);
+            walker.Walk(node);
             return walker.CyclomaticComplexity;
         }
 

diff --git a/sonaranalyzer-dotnet/src/SonarAnalyzer.CSharp/Rules/FunctionComplexity.cs b/sonaranalyzer-dotnet/src/SonarAnalyzer.CSharp/Rules/FunctionComplexity.cs
@@ -96,7 +96,7 @@ protected void CheckComplexity<TSyntax>(SyntaxNodeAnalysisContext context, Func<
                 return;
             }
 
-            walker.Visit(nodeToCheck);
+            walker.Walk(nodeToCheck);
 
             if (walker.CyclomaticComplexity > Maximum)
             {

diff --git a/sonaranalyzer-dotnet/src/Tests/SonarAnalyzer.UnitTest/Rules/CognitiveComplexityTest.cs b/sonaranalyzer-dotnet/src/Tests/SonarAnalyzer.UnitTest/Rules/CognitiveComplexityTest.cs
@@ -38,7 +38,7 @@ public void CognitiveComplexity()
         [TestCategory("Rule")]
         public void CognitiveComplexity_StackOverflow()
         {
-            Verifier.VerifyAnalyzer(@"TestCases\CognitiveComplexity_InsufficientExecutionStackException.cs",
+            Verifier.VerifyAnalyzer(@"TestCases\SyntaxWalker_InsufficientExecutionStackException.cs",
                 new CognitiveComplexity { Threshold = 0, PropertyThreshold = 0 });
         }
     }

diff --git a/sonaranalyzer-dotnet/src/Tests/SonarAnalyzer.UnitTest/Rules/FunctionComplexityTest.cs b/sonaranalyzer-dotnet/src/Tests/SonarAnalyzer.UnitTest/Rules/FunctionComplexityTest.cs
@@ -29,10 +29,18 @@ public class FunctionComplexityTest
         [TestCategory("Rule")]
         public void FunctionComplexity_CSharp()
         {
-            var diagnostic = new SonarAnalyzer.Rules.CSharp.FunctionComplexity { Maximum = 3};
+            var diagnostic = new SonarAnalyzer.Rules.CSharp.FunctionComplexity { Maximum = 3 };
             Verifier.VerifyAnalyzer(@"TestCases\FunctionComplexity.cs", diagnostic);
         }
 
+        [TestMethod]
+        [TestCategory("Rule")]
+        public void FunctionComplexity_InsufficientExecutionStack_CSharp()
+        {
+            var diagnostic = new SonarAnalyzer.Rules.CSharp.FunctionComplexity { Maximum = 3 };
+            Verifier.VerifyAnalyzer(@"TestCases\SyntaxWalker_InsufficientExecutionStackException.cs", diagnostic);
+        }
+
         [TestMethod]
         [TestCategory("Rule")]
         public void FunctionComplexity_VisualBasic()