Fix S4056: FP for overloads with different signature (#2379)

SonarSource · Apr 24, 2019 · c2366e4 · c2366e4
1 parent 30fc149
commit c2366e4
Show file tree

Hide file tree

Showing 47 changed files with 238 additions and 2,582 deletions.
diff --git a/...dotnet/its/expected/Automapper/AutoMapper-025B9F93-7953-454B-AF29-E6A55B2AA58F-S4056.json b/...dotnet/its/expected/Automapper/AutoMapper-025B9F93-7953-454B-AF29-E6A55B2AA58F-S4056.json
@@ -17,97 +17,6 @@
 "id":  "S4056",
 "message":  "Use the overload that takes a 'CultureInfo' or 'IFormatProvider' parameter.",
 "location":  {
-"uri":  "sources\Automapper\src\AutoMapper\AutoMapperConfigurationException.cs",
-"region":  {
-"startLine":  121,
-"startColumn":  44,
-"endLine":  121,
-"endColumn":  88
-}
-}
-},
-{
-"id":  "S4056",
-"message":  "Use the overload that takes a 'CultureInfo' or 'IFormatProvider' parameter.",
-"location":  {
-"uri":  "sources\Automapper\src\AutoMapper\Configuration\Conventions\ReplaceName.cs",
-"region":  {
-"startLine":  39,
-"startColumn":  49,
-"endLine":  39,
-"endColumn":  98
-}
-}
-},
-{
-"id":  "S4056",
-"message":  "Use the overload that takes a 'CultureInfo' or 'IFormatProvider' parameter.",
-"location":  {
-"uri":  "sources\Automapper\src\AutoMapper\Configuration\Conventions\ReplaceName.cs",
-"region":  {
-"startLine":  40,
-"startColumn":  91,
-"endLine":  40,
-"endColumn":  129
-}
-}
-},
-{
-"id":  "S4056",
-"message":  "Use the overload that takes a 'CultureInfo' or 'IFormatProvider' parameter.",
-"location":  {
-"uri":  "sources\Automapper\src\AutoMapper\Execution\ProxyGenerator.cs",
-"region":  {
-"startLine":  159,
-"startColumn":  32,
-"endLine":  159,
-"endColumn":  71
-}
-}
-},
-{
-"id":  "S4056",
-"message":  "Use the overload that takes a 'CultureInfo' or 'IFormatProvider' parameter.",
-"location":  {
-"uri":  "sources\Automapper\src\AutoMapper\Internal\ReflectionHelper.cs",
-"region":  {
-"startLine":  46,
-"startColumn":  17,
-"endLine":  46,
-"endColumn":  55
-}
-}
-},
-{
-"id":  "S4056",
-"message":  "Use the overload that takes a 'CultureInfo' or 'IFormatProvider' parameter.",
-"location":  {
-"uri":  "sources\Automapper\src\AutoMapper\Internal\ReflectionHelper.cs",
-"region":  {
-"startLine":  51,
-"startColumn":  17,
-"endLine":  51,
-"endColumn":  46
-}
-}
-},
-{
-"id":  "S4056",
-"message":  "Use the overload that takes a 'CultureInfo' or 'IFormatProvider' parameter.",
-"location":  {
-"uri":  "sources\Automapper\src\AutoMapper\Internal\ReflectionHelper.cs",
-"region":  {
-"startLine":  64,
-"startColumn":  24,
-"endLine":  64,
-"endColumn":  55
-}
-}
-},
-{
-"id":  "S4056",
-"message":  "Use the overload that takes a 'CultureInfo' or 'IFormatProvider' parameter.",
-"location":  {
 "uri":  "sources\Automapper\src\AutoMapper\LowerUnderscoreNamingConvention.cs",
 "region":  {
 "startLine":  11,
@@ -147,32 +56,6 @@
 "id":  "S4056",
 "message":  "Use the overload that takes a 'CultureInfo' or 'IFormatProvider' parameter.",
 "location":  {
-"uri":  "sources\Automapper\src\AutoMapper\Mappers\TypeConverterMapper.cs",
-"region":  {
-"startLine":  18,
-"startColumn":  38,
-"endLine":  18,
-"endColumn":  91
-}
-}
-},
-{
-"id":  "S4056",
-"message":  "Use the overload that takes a 'CultureInfo' or 'IFormatProvider' parameter.",
-"location":  {
-"uri":  "sources\Automapper\src\AutoMapper\Mappers\TypeConverterMapper.cs",
-"region":  {
-"startLine":  24,
-"startColumn":  38,
-"endLine":  24,
-"endColumn":  71
-}
-}
-},
-{
-"id":  "S4056",
-"message":  "Use the overload that takes a 'CultureInfo' or 'IFormatProvider' parameter.",
-"location":  {
 "uri":  "sources\Automapper\src\AutoMapper\PascalCaseNamingConvention.cs",
 "region":  {
 "startLine":  10,
@@ -194,32 +77,6 @@
 "endColumn":  87
 }
 }
-},
-{
-"id":  "S4056",
-"message":  "Use the overload that takes a 'CultureInfo' or 'IFormatProvider' parameter.",
-"location":  {
-"uri":  "sources\Automapper\src\AutoMapper\QueryableExtensions\Impl\QueryMapperVisitor.cs",
-"region":  {
-"startLine":  156,
-"startColumn":  21,
-"endLine":  156,
-"endColumn":  70
-}
-}
-},
-{
-"id":  "S4056",
-"message":  "Use the overload that takes a 'CultureInfo' or 'IFormatProvider' parameter.",
-"location":  {
-"uri":  "sources\Automapper\src\AutoMapper\QueryableExtensions\ProjectionExpression.cs",
-"region":  {
-"startLine":  45,
-"startColumn":  52,
-"endLine":  45,
-"endColumn":  81
-}
-}
 }
 ]
 }
diff --git a/...ed/Automapper/AutoMapper.IntegrationTests-1EE3612B-FCA4-4DA5-BA9E-741A9D8DC59E-S4056.json b/...ed/Automapper/AutoMapper.IntegrationTests-1EE3612B-FCA4-4DA5-BA9E-741A9D8DC59E-S4056.json
@@ -4,19 +4,6 @@
 "id":  "S4056",
 "message":  "Use the overload that takes a 'CultureInfo' or 'IFormatProvider' parameter.",
 "location":  {
-"uri":  "sources\Automapper\src\IntegrationTests\ExplicitExpansion\ProjectionWithExplicitExpansion.cs",
-"region":  {
-"startLine":  77,
-"startColumn":  71,
-"endLine":  77,
-"endColumn":  105
-}
-}
-},
-{
-"id":  "S4056",
-"message":  "Use the overload that takes a 'CultureInfo' or 'IFormatProvider' parameter.",
-"location":  {
 "uri":  "sources\Automapper\src\IntegrationTests\Inheritance\ProjectToAbstractType.cs",
 "region":  {
 "startLine":  273,

diff --git a/...net/its/expected/Ember-MM/Ember.Plugins-{9496C697-5AFD-4813-AEDC-AF33FACEADF0}-S4056.json b/...net/its/expected/Ember-MM/Ember.Plugins-{9496C697-5AFD-4813-AEDC-AF33FACEADF0}-S4056.json
@@ -19,19 +19,6 @@
 "location":  {
 "uri":  "sources\Ember-MM\Ember.Plugins\Ember\EmberWorkAroundPlugin.cs",
 "region":  {
-"startLine":  63,
-"startColumn":  17,
-"endLine":  63,
-"endColumn":  41
-}
-}
-},
-{
-"id":  "S4056",
-"message":  "Use the overload that takes a 'CultureInfo' or 'IFormatProvider' parameter.",
-"location":  {
-"uri":  "sources\Ember-MM\Ember.Plugins\Ember\EmberWorkAroundPlugin.cs",
-"region":  {
 "startLine":  64,
 "startColumn":  25,
 "endLine":  64,
@@ -45,19 +32,6 @@
 "location":  {
 "uri":  "sources\Ember-MM\Ember.Plugins\Ember\EmberWorkAroundPlugin.cs",
 "region":  {
-"startLine":  65,
-"startColumn":  22,
-"endLine":  65,
-"endColumn":  44
-}
-}
-},
-{
-"id":  "S4056",
-"message":  "Use the overload that takes a 'CultureInfo' or 'IFormatProvider' parameter.",
-"location":  {
-"uri":  "sources\Ember-MM\Ember.Plugins\Ember\EmberWorkAroundPlugin.cs",
-"region":  {
 "startLine":  66,
 "startColumn":  25,
 "endLine":  66,
@@ -71,19 +45,6 @@
 "location":  {
 "uri":  "sources\Ember-MM\Ember.Plugins\Ember\EmberWorkAroundPlugin.cs",
 "region":  {
-"startLine":  67,
-"startColumn":  22,
-"endLine":  67,
-"endColumn":  45
-}
-}
-},
-{
-"id":  "S4056",
-"message":  "Use the overload that takes a 'CultureInfo' or 'IFormatProvider' parameter.",
-"location":  {
-"uri":  "sources\Ember-MM\Ember.Plugins\Ember\EmberWorkAroundPlugin.cs",
-"region":  {
 "startLine":  68,
 "startColumn":  25,
 "endLine":  68,
@@ -194,19 +155,6 @@
 "endColumn":  70
 }
 }
-},
-{
-"id":  "S4056",
-"message":  "Use the overload that takes a 'CultureInfo' or 'IFormatProvider' parameter.",
-"location":  {
-"uri":  "sources\Ember-MM\Ember.Plugins\Utility.cs",
-"region":  {
-"startLine":  44,
-"startColumn":  22,
-"endLine":  44,
-"endColumn":  45
-}
-}
 }
 ]
 }