Update S1144: Add exceptions from RSPEC description (#2206)

SonarSource · Jan 4, 2019 · a6997ec · a6997ec
1 parent c0124c4
commit a6997ec
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/sonaranalyzer-dotnet/rspec/cs/S1144_c#.html b/sonaranalyzer-dotnet/rspec/cs/S1144_c#.html
@@ -14,7 +14,7 @@ <h2>Compliant Solution</h2>
 <pre>
 public class Foo
 {
-  private Foo()
+  public Foo()
   {
     UsedPrivateMethod();
   }
@@ -28,10 +28,12 @@ <h2>Compliant Solution</h2>
 }
 </pre>
 <h2>Exceptions</h2>
-<p>This rule doesn't raise any issue on:</p>
+<p>This rule doesn't raise issues on:</p>
 <ul>
   <li> Empty constructors </li>
   <li> Attributed members </li>
+  <li> <code>Main</code> method </li>
+  <li> Methods with event handler signature <code>void Foo(object, EventArgs)</code> that are declared in partial class </li>
   <li> Empty serialization constructor on type with <code>System.SerializableAttribute</code> attribute. </li>
   <li> Internals in assemblies that have a <code>System.Runtime.CompilerServices.InternalsVisibleToAttribute</code> attribute. </li>
 </ul>

diff --git a/sonaranalyzer-dotnet/src/SonarAnalyzer.Utilities/Rules.Description/S1144.html b/sonaranalyzer-dotnet/src/SonarAnalyzer.Utilities/Rules.Description/S1144.html
@@ -14,7 +14,7 @@ <h2>Compliant Solution</h2>
 <pre>
 public class Foo
 {
-  private Foo()
+  public Foo()
   {
     UsedPrivateMethod();
   }
@@ -28,10 +28,12 @@ <h2>Compliant Solution</h2>
 }
 </pre>
 <h2>Exceptions</h2>
-<p>This rule doesn't raise any issue on:</p>
+<p>This rule doesn't raise issues on:</p>
 <ul>
   <li> Empty constructors </li>
   <li> Attributed members </li>
+  <li> <code>Main</code> method </li>
+  <li> Methods with event handler signature <code>void Foo(object, EventArgs)</code> that are declared in partial class </li>
   <li> Empty serialization constructor on type with <code>System.SerializableAttribute</code> attribute. </li>
   <li> Internals in assemblies that have a <code>System.Runtime.CompilerServices.InternalsVisibleToAttribute</code> attribute. </li>
 </ul>