More tests and reverting rspec change.

SonarSource · Jun 20, 2017 · 54ddb5a · 54ddb5a
1 parent e775934
commit 54ddb5a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/sonaranalyzer-dotnet/src/SonarAnalyzer.CSharp/RspecStrings.resx b/sonaranalyzer-dotnet/src/SonarAnalyzer.CSharp/RspecStrings.resx
@@ -2233,7 +2233,7 @@
     <value>misra,cert</value>
   </data>
   <data name="S2201_Title" xml:space="preserve">
-    <value>Return values should not be ignored when function calls don't have any side effects</value>
+    <value>Return values from functions without side effects should not be ignored</value>
   </data>
   <data name="S2201_Type" xml:space="preserve">
     <value>BUG</value>

diff --git a/sonaranalyzer-dotnet/src/Tests/SonarAnalyzer.UnitTest/TestCases/DoNotCatchSystemException.cs b/sonaranalyzer-dotnet/src/Tests/SonarAnalyzer.UnitTest/TestCases/DoNotCatchSystemException.cs
@@ -55,7 +55,13 @@ public void Method()
             }
 
             try { }
-            catch (Exception e) // Noncompliant
+            catch (Exception) // Noncompliant
+            {
+                new Exception();
+            }
+
+            try { }
+            catch (IOException)
             {
                 new Exception();
             }
@@ -71,6 +77,12 @@ public void Method()
 //          ^^^^^
             {
             }
+
+            try { }
+            catch (DummyType)
+            {
+                throw;
+            }
         }
     }
 }