Fix S1200: Exclude Action, Func and Task from counting; included meth…

…od return types, events, indexer parameters and generics; structs and interfaces included;
SonarSource · Jun 13, 2018 · 35f861e · 35f861e
1 parent ffcfdb7
commit 35f861e
Show file tree

Hide file tree

Showing 21 changed files with 638 additions and 426 deletions.
diff --git a/...nalyzer-dotnet/its/expected/Nancy/Nancy-{34576216-0DCA-4B0F-A0DC-9075E75A676F}-S1200.json b/...nalyzer-dotnet/its/expected/Nancy/Nancy-{34576216-0DCA-4B0F-A0DC-9075E75A676F}-S1200.json
@@ -2,7 +2,7 @@
 "issues":  [
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 50 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 42 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy\Bootstrapper\NancyBootstrapperBase.cs",
 "region":  {
@@ -15,7 +15,7 @@
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 99 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 98 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy\Bootstrapper\NancyInternalConfiguration.cs",
 "region":  {
@@ -28,20 +28,7 @@
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 26 to the maximum authorized 20 or less.",
-"location":  {
-"uri":  "sources\Nancy\src\Nancy\Bootstrapper\Registrations.cs",
-"region":  {
-"startLine":  10,
-"startColumn":  27,
-"endLine":  10,
-"endColumn":  40
-}
-}
-},
-{
-"id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 29 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 22 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy\DefaultNancyBootstrapper.cs",
 "region":  {
@@ -54,7 +41,7 @@
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 57 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 52 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy\Diagnostics\DiagnosticsHook.cs",
 "region":  {
@@ -67,7 +54,7 @@
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 23 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 24 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy\Diagnostics\DiagnosticsModuleCatalog.cs",
 "region":  {
@@ -80,46 +67,46 @@
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 24 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 21 to the maximum authorized 20 or less.",
 "location":  {
-"uri":  "sources\Nancy\src\Nancy\Diagnostics\InteractiveDiagnostics.cs",
+"uri":  "sources\Nancy\src\Nancy\Diagnostics\DiagnosticsViewRenderer.cs",
 "region":  {
-"startLine":  10,
+"startLine":  15,
 "startColumn":  18,
-"endLine":  10,
-"endColumn":  40
+"endLine":  15,
+"endColumn":  41
 }
 }
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 39 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 21 to the maximum authorized 20 or less.",
 "location":  {
-"uri":  "sources\Nancy\src\Nancy\Json\JavaScriptSerializer.cs",
+"uri":  "sources\Nancy\src\Nancy\DynamicDictionaryValue.cs",
 "region":  {
-"startLine":  42,
+"startLine":  12,
 "startColumn":  18,
-"endLine":  42,
-"endColumn":  38
+"endLine":  12,
+"endColumn":  40
 }
 }
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 21 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 33 to the maximum authorized 20 or less.",
 "location":  {
-"uri":  "sources\Nancy\src\Nancy\Json\JsonDeserializer.cs",
+"uri":  "sources\Nancy\src\Nancy\Json\JavaScriptSerializer.cs",
 "region":  {
-"startLine":  69,
-"startColumn":  27,
-"endLine":  69,
-"endColumn":  43
+"startLine":  42,
+"startColumn":  18,
+"endLine":  42,
+"endColumn":  38
 }
 }
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 40 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 34 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy\Json\JsonSerializer.cs",
 "region":  {
@@ -132,7 +119,7 @@
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 32 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 30 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy\ModelBinding\DefaultBinder.cs",
 "region":  {
@@ -145,20 +132,7 @@
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 41 to the maximum authorized 20 or less.",
-"location":  {
-"uri":  "sources\Nancy\src\Nancy\ModelBinding\ModuleExtensions.cs",
-"region":  {
-"startLine":  10,
-"startColumn":  25,
-"endLine":  10,
-"endColumn":  41
-}
-}
-},
-{
-"id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 31 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 28 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy\NancyEngine.cs",
 "region":  {
@@ -171,20 +145,20 @@
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 28 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 21 to the maximum authorized 20 or less.",
 "location":  {
-"uri":  "sources\Nancy\src\Nancy\Owin\NancyMiddleware.cs",
+"uri":  "sources\Nancy\src\Nancy\NancyModule.cs",
 "region":  {
-"startLine":  27,
-"startColumn":  25,
-"endLine":  27,
-"endColumn":  40
+"startLine":  19,
+"startColumn":  27,
+"endLine":  19,
+"endColumn":  38
 }
 }
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 34 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 29 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy\Request.cs",
 "region":  {
@@ -197,20 +171,7 @@
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 26 to the maximum authorized 20 or less.",
-"location":  {
-"uri":  "sources\Nancy\src\Nancy\RequestHeaders.cs",
-"region":  {
-"startLine":  15,
-"startColumn":  18,
-"endLine":  15,
-"endColumn":  32
-}
-}
-},
-{
-"id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 35 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 25 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy\Responses\Negotiation\DefaultResponseNegotiator.cs",
 "region":  {
@@ -223,20 +184,7 @@
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 22 to the maximum authorized 20 or less.",
-"location":  {
-"uri":  "sources\Nancy\src\Nancy\Routing\DefaultRequestDispatcher.cs",
-"region":  {
-"startLine":  15,
-"startColumn":  18,
-"endLine":  15,
-"endColumn":  42
-}
-}
-},
-{
-"id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 26 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 24 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy\Session\CookieBasedSessions.cs",
 "region":  {
@@ -249,7 +197,7 @@
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 96 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 37 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy\TinyIoc\TinyIoC.cs",
 "region":  {
@@ -262,7 +210,7 @@
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 24 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 22 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy\ViewEngines\DefaultViewFactory.cs",
 "region":  {
@@ -275,7 +223,7 @@
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 35 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 30 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy\ViewEngines\SuperSimpleViewEngine\SuperSimpleViewEngine.cs",
 "region":  {

diff --git a/...y.Demo.Authentication.Forms.TestingDemo-{948A8EF6-D50C-45EA-9AFD-7A4723ADAB0B}-S1200.json b/...y.Demo.Authentication.Forms.TestingDemo-{948A8EF6-D50C-45EA-9AFD-7A4723ADAB0B}-S1200.json
diff --git a/.../expected/Nancy/Nancy.Demo.CustomModule-{F56F3983-0C34-4AEC-B418-A8AFFA63F1C4}-S1200.json b/.../expected/Nancy/Nancy.Demo.CustomModule-{F56F3983-0C34-4AEC-B418-A8AFFA63F1C4}-S1200.json
@@ -2,7 +2,7 @@
 "issues":  [
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 27 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 23 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy.Demo.CustomModule\UglifiedNancyModule.cs",
 "region":  {

diff --git a/...its/expected/Nancy/Nancy.Hosting.Aspnet-{15B7F794-0BB2-4B66-AD78-4A951F1209B2}-S1200.json b/...its/expected/Nancy/Nancy.Hosting.Aspnet-{15B7F794-0BB2-4B66-AD78-4A951F1209B2}-S1200.json
diff --git a/...t/its/expected/Nancy/Nancy.Hosting.Self-{AA7F66EB-EC2C-47DE-855F-30B3E6EF2134}-S1200.json b/...t/its/expected/Nancy/Nancy.Hosting.Self-{AA7F66EB-EC2C-47DE-855F-30B3E6EF2134}-S1200.json
@@ -2,7 +2,7 @@
 "issues":  [
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 37 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 36 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy.Hosting.Self\NancyHost.cs",
 "region":  {

diff --git a/...dotnet/its/expected/Nancy/Nancy.Testing-{D79203C0-B672-4751-9C95-C3AB7D3FEFBE}-S1200.json b/...dotnet/its/expected/Nancy/Nancy.Testing-{D79203C0-B672-4751-9C95-C3AB7D3FEFBE}-S1200.json
@@ -2,7 +2,7 @@
 "issues":  [
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 23 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 21 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy.Testing\Browser.cs",
 "region":  {
@@ -15,7 +15,7 @@
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 24 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 21 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy.Testing\BrowserContextExtensions.cs",
 "region":  {
@@ -28,7 +28,7 @@
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 60 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 43 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy.Testing\ConfigurableBootstrapper.cs",
 "region":  {
@@ -41,7 +41,7 @@
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 133 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 68 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy.Testing\ConfigurableBootstrapper.cs",
 "region":  {

diff --git a/.../expected/Nancy/Nancy.ViewEngines.Razor-{2C6F51DF-015C-4DB6-B44C-0E5E4F25E2A9}-S1200.json b/.../expected/Nancy/Nancy.ViewEngines.Razor-{2C6F51DF-015C-4DB6-B44C-0E5E4F25E2A9}-S1200.json
@@ -2,7 +2,7 @@
 "issues":  [
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 28 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 23 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy.ViewEngines.Razor\NancyRazorViewBase.cs",
 "region":  {
@@ -15,7 +15,7 @@
 },
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 50 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 44 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy.ViewEngines.Razor\RazorViewEngine.cs",
 "region":  {

diff --git a/.../expected/Nancy/Nancy.ViewEngines.Spark-{4B7E35DF-1569-4346-B180-A09615723095}-S1200.json b/.../expected/Nancy/Nancy.ViewEngines.Spark-{4B7E35DF-1569-4346-B180-A09615723095}-S1200.json
@@ -2,7 +2,7 @@
 "issues":  [
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 30 to the maximum authorized 20 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 28 to the maximum authorized 20 or less.",
 "location":  {
 "uri":  "sources\Nancy\src\Nancy.ViewEngines.Spark\SparkViewEngine.cs",
 "region":  {