Revert "Rule S3433: Test methods should have correct signature" (#647)

This reverts commit c22b63d.
SonarSource · Aug 4, 2017 · 1600df4 · 1600df4
1 parent c00ee47
commit 1600df4
Show file tree

Hide file tree

Showing 12 changed files with 1 addition and 405 deletions.
diff --git a/sonaranalyzer-dotnet/rspec/cs/S3433_c#.html b/sonaranalyzer-dotnet/rspec/cs/S3433_c#.html
diff --git a/sonaranalyzer-dotnet/rspec/cs/S3433_c#.json b/sonaranalyzer-dotnet/rspec/cs/S3433_c#.json
diff --git a/sonaranalyzer-dotnet/rspec/cs/Sonar_way_profile.json b/sonaranalyzer-dotnet/rspec/cs/Sonar_way_profile.json
@@ -125,7 +125,6 @@
     "S3376",
     "S3397",
     "S3427",
-    "S3433",
     "S3440",
     "S3442",
     "S3443",

diff --git a/sonaranalyzer-dotnet/src/SonarAnalyzer.CSharp/RspecStrings.resx b/sonaranalyzer-dotnet/src/SonarAnalyzer.CSharp/RspecStrings.resx
@@ -4911,33 +4911,6 @@
   <data name="S3427_Type" xml:space="preserve">
     <value>CODE_SMELL</value>
   </data>
-  <data name="S3433_Category" xml:space="preserve">
-    <value>Sonar Code Smell</value>
-  </data>
-  <data name="S3433_Description" xml:space="preserve">
-    <value>Whether or not they have a test attribute, non-public methods are not recognized as tests, and therefore not executed.</value>
-  </data>
-  <data name="S3433_IsActivatedByDefault" xml:space="preserve">
-    <value>True</value>
-  </data>
-  <data name="S3433_Remediation" xml:space="preserve">
-    <value>Constant/Issue</value>
-  </data>
-  <data name="S3433_RemediationCost" xml:space="preserve">
-    <value>2min</value>
-  </data>
-  <data name="S3433_Severity" xml:space="preserve">
-    <value>Blocker</value>
-  </data>
-  <data name="S3433_Tags" xml:space="preserve">
-    <value>tests</value>
-  </data>
-  <data name="S3433_Title" xml:space="preserve">
-    <value>Test method signatures should be correct</value>
-  </data>
-  <data name="S3433_Type" xml:space="preserve">
-    <value>CODE_SMELL</value>
-  </data>
   <data name="S3440_Category" xml:space="preserve">
     <value>Sonar Code Smell</value>
   </data>

diff --git a/sonaranalyzer-dotnet/src/SonarAnalyzer.CSharp/Rules/TestMethodShouldHaveCorrectSignature.cs b/sonaranalyzer-dotnet/src/SonarAnalyzer.CSharp/Rules/TestMethodShouldHaveCorrectSignature.cs
diff --git a/sonaranalyzer-dotnet/src/SonarAnalyzer.Common/Helpers/KnownType.cs b/sonaranalyzer-dotnet/src/SonarAnalyzer.Common/Helpers/KnownType.cs
@@ -329,11 +329,6 @@ internal sealed class KnownType
 
         public static readonly KnownType System_Xml_XmlDocument = new KnownType("System.Xml.XmlDocument");
 
-        public static readonly KnownType Microsoft_VisualStudio_TestTools_UnitTesting_TestMethodAttribute =
-            new KnownType("Microsoft.VisualStudio.TestTools.UnitTesting.TestMethodAttribute");
-        public static readonly KnownType Xunit_FactAttribute = new KnownType("Xunit.FactAttribute");
-        public static readonly KnownType NUnit_Framework_TestAttribute = new KnownType("NUnit.Framework.TestAttribute");
-
         #endregion
 
         public string TypeName { get; }

diff --git a/sonaranalyzer-dotnet/src/SonarAnalyzer.Utilities/Rules.Description/S3433.html b/sonaranalyzer-dotnet/src/SonarAnalyzer.Utilities/Rules.Description/S3433.html
diff --git a/sonaranalyzer-dotnet/src/Tests/SonarAnalyzer.UnitTest/PackagingTests/RuleTypeTests.cs b/sonaranalyzer-dotnet/src/Tests/SonarAnalyzer.UnitTest/PackagingTests/RuleTypeTests.cs
@@ -3430,7 +3430,7 @@ private static void DetectTypeChanges(ResourceManager resourceManager, IImmutabl
             //["3430"],
             //["3431"],
             //["3432"],
-            ["3433"] = "CODE_SMELL",
+            //["3433"],
             //["3434"],
             //["3435"],
             //["3436"],

diff --git a/...dotnet/src/Tests/SonarAnalyzer.UnitTest/Rules/TestMethodShouldHaveCorrectSignatureTest.cs b/...dotnet/src/Tests/SonarAnalyzer.UnitTest/Rules/TestMethodShouldHaveCorrectSignatureTest.cs
diff --git a/sonaranalyzer-dotnet/src/Tests/SonarAnalyzer.UnitTest/SonarAnalyzer.UnitTest.csproj b/sonaranalyzer-dotnet/src/Tests/SonarAnalyzer.UnitTest/SonarAnalyzer.UnitTest.csproj
@@ -73,10 +73,6 @@
       <HintPath>..\..\..\packages\Microsoft.CodeAnalysis.Workspaces.Common.1.0.0\lib\net45\Microsoft.CodeAnalysis.Workspaces.Desktop.dll</HintPath>
       <Private>True</Private>
     </Reference>
-    <Reference Include="nunit.framework, Version=3.7.1.0, Culture=neutral, PublicKeyToken=2638cd05610744eb, processorArchitecture=MSIL">
-      <HintPath>..\..\..\packages\NUnit.3.7.1\lib\net45\nunit.framework.dll</HintPath>
-      <Private>True</Private>
-    </Reference>
     <Reference Include="Oracle.ManagedDataAccess, Version=4.122.1.0, Culture=neutral, PublicKeyToken=89b483f429c47342, processorArchitecture=MSIL">
       <HintPath>..\..\..\packages\Oracle.ManagedDataAccess.12.2.1100\lib\net40\Oracle.ManagedDataAccess.dll</HintPath>
       <Private>True</Private>
@@ -117,22 +113,6 @@
     </Reference>
     <Reference Include="System.Xml" />
     <Reference Include="System.Xml.Linq" />
-    <Reference Include="xunit.abstractions, Version=2.0.0.0, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c, processorArchitecture=MSIL">
-      <HintPath>..\..\..\packages\xunit.abstractions.2.0.1\lib\net35\xunit.abstractions.dll</HintPath>
-      <Private>True</Private>
-    </Reference>
-    <Reference Include="xunit.assert, Version=2.2.0.3545, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c, processorArchitecture=MSIL">
-      <HintPath>..\..\..\packages\xunit.assert.2.2.0\lib\netstandard1.1\xunit.assert.dll</HintPath>
-      <Private>True</Private>
-    </Reference>
-    <Reference Include="xunit.core, Version=2.2.0.3545, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c, processorArchitecture=MSIL">
-      <HintPath>..\..\..\packages\xunit.extensibility.core.2.2.0\lib\netstandard1.1\xunit.core.dll</HintPath>
-      <Private>True</Private>
-    </Reference>
-    <Reference Include="xunit.execution.desktop, Version=2.2.0.3545, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c, processorArchitecture=MSIL">
-      <HintPath>..\..\..\packages\xunit.extensibility.execution.2.2.0\lib\net452\xunit.execution.desktop.dll</HintPath>
-      <Private>True</Private>
-    </Reference>
   </ItemGroup>
   <Choose>
     <When Condition="('$(VisualStudioVersion)' == '10.0' or '$(VisualStudioVersion)' == '') and '$(TargetFrameworkVersion)' == 'v3.5'">